Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 04:30:10 +01:00
Code Issues Projects Releases Packages Wiki Activity

Start marking functions that can transitively trigger a GC (#33144)

Browse source 
* Mark JS reflector wrappers as CanGc.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Propagate CanGc from reflect_dom_object_with_proto.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Mark DOM constructors as GC operations.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

---------

Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
Josh Matthews 2024-08-22 07:42:36 -04:00 • committed by GitHub
parent 9a1051c917
commit 60ef6bc461
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
140 changed files with 1336 additions and 304 deletions
Download patch file Download diff file Expand all files Collapse all files

17
components/script/dom/hashchangeevent.rs
View file

@ -16,6 +16,7 @@ use crate::dom::bindings::root::DomRoot;
use crate::dom::bindings::str::{DOMString, USVString};
use crate::dom::event::Event;
use crate::dom::window::Window;
use crate::script_runtime::CanGc;
// https://html.spec.whatwg.org/multipage/#hashchangeevent
#[dom_struct]
@ -46,6 +47,7 @@ impl HashChangeEvent {
Box::new(HashChangeEvent::new_inherited(String::new(), String::new())),
window,
proto,
CanGc::note(),
)
}
@ -57,7 +59,16 @@ impl HashChangeEvent {
old_url: String,
new_url: String,
) -> DomRoot<HashChangeEvent> {
Self::new_with_proto(window, None, type_, bubbles, cancelable, old_url, new_url)
Self::new_with_proto(
window,
None,
type_,
bubbles,
cancelable,
old_url,
new_url,
CanGc::note(),
)
}
fn new_with_proto(
@ -68,11 +79,13 @@ impl HashChangeEvent {
cancelable: bool,
old_url: String,
new_url: String,
can_gc: CanGc,
) -> DomRoot<HashChangeEvent> {
let ev = reflect_dom_object_with_proto(
Box::new(HashChangeEvent::new_inherited(old_url, new_url)),
window,
proto,
can_gc,
);
{
let event = ev.upcast::<Event>();
@ -85,6 +98,7 @@ impl HashChangeEvent {
pub fn Constructor(
window: &Window,
proto: Option<HandleObject>,
can_gc: CanGc,
type_: DOMString,
init: &HashChangeEventBinding::HashChangeEventInit,
) -> Fallible<DomRoot<HashChangeEvent>> {
@ -96,6 +110,7 @@ impl HashChangeEvent {
init.parent.cancelable,
init.oldURL.0.clone(),
init.newURL.0.clone(),
can_gc,
))
}
}