Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 14:10:11 +01:00
Code Issues Projects Releases Packages Wiki Activity

Start marking functions that can transitively trigger a GC (#33144)

Browse source 
* Mark JS reflector wrappers as CanGc.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Propagate CanGc from reflect_dom_object_with_proto.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Mark DOM constructors as GC operations.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

---------

Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
Josh Matthews 2024-08-22 07:42:36 -04:00 • committed by GitHub
parent 9a1051c917
commit 60ef6bc461
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
140 changed files with 1336 additions and 304 deletions
Download patch file Download diff file Expand all files Collapse all files

17
components/script/dom/keyboardevent.rs
View file

@ -20,6 +20,7 @@ use crate::dom::bindings::str::DOMString;
use crate::dom::event::Event;
use crate::dom::uievent::UIEvent;
use crate::dom::window::Window;
use crate::script_runtime::CanGc;
#[dom_struct]
pub struct KeyboardEvent {
@ -54,14 +55,20 @@ impl KeyboardEvent {
}
pub fn new_uninitialized(window: &Window) -> DomRoot<KeyboardEvent> {
Self::new_uninitialized_with_proto(window, None)
Self::new_uninitialized_with_proto(window, None, CanGc::note())
}
fn new_uninitialized_with_proto(
window: &Window,
proto: Option<HandleObject>,
can_gc: CanGc,
) -> DomRoot<KeyboardEvent> {
reflect_dom_object_with_proto(Box::new(KeyboardEvent::new_inherited()), window, proto)
reflect_dom_object_with_proto(
Box::new(KeyboardEvent::new_inherited()),
window,
proto,
can_gc,
)
}
#[allow(clippy::too_many_arguments)]
@ -97,6 +104,7 @@ impl KeyboardEvent {
modifiers,
char_code,
key_code,
CanGc::note(),
)
}
@ -117,8 +125,9 @@ impl KeyboardEvent {
modifiers: Modifiers,
char_code: u32,
key_code: u32,
can_gc: CanGc,
) -> DomRoot<KeyboardEvent> {
let ev = KeyboardEvent::new_uninitialized_with_proto(window, proto);
let ev = KeyboardEvent::new_uninitialized_with_proto(window, proto, can_gc);
ev.InitKeyboardEvent(
type_,
can_bubble,
@ -143,6 +152,7 @@ impl KeyboardEvent {
pub fn Constructor(
window: &Window,
proto: Option<HandleObject>,
can_gc: CanGc,
type_: DOMString,
init: &KeyboardEventBinding::KeyboardEventInit,
) -> Fallible<DomRoot<KeyboardEvent>> {
@ -167,6 +177,7 @@ impl KeyboardEvent {
modifiers,
0,
0,
can_gc,
);
*event.key.borrow_mut() = init.key.clone();
Ok(event)