Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-07 22:45:34 +01:00
Code Issues Projects Releases Packages Wiki Activity

Start marking functions that can transitively trigger a GC (#33144)

Browse source 
* Mark JS reflector wrappers as CanGc.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Propagate CanGc from reflect_dom_object_with_proto.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Mark DOM constructors as GC operations.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

---------

Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
Josh Matthews 2024-08-22 07:42:36 -04:00 • committed by GitHub
parent 9a1051c917
commit 60ef6bc461
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
140 changed files with 1336 additions and 304 deletions
Download patch file Download diff file Expand all files Collapse all files

14
components/script/dom/mediametadata.rs
View file

@ -15,6 +15,7 @@ use crate::dom::bindings::root::{DomRoot, MutNullableDom};
use crate::dom::bindings::str::DOMString;
use crate::dom::mediasession::MediaSession;
use crate::dom::window::Window;
use crate::script_runtime::CanGc;
#[dom_struct]
pub struct MediaMetadata {
@ -37,15 +38,21 @@ impl MediaMetadata {
}
pub fn new(global: &Window, init: &MediaMetadataInit) -> DomRoot<MediaMetadata> {
Self::new_with_proto(global, None, init)
Self::new_with_proto(global, None, init, CanGc::note())
}
fn new_with_proto(
global: &Window,
proto: Option<HandleObject>,
init: &MediaMetadataInit,
can_gc: CanGc,
) -> DomRoot<MediaMetadata> {
reflect_dom_object_with_proto(Box::new(MediaMetadata::new_inherited(init)), global, proto)
reflect_dom_object_with_proto(
Box::new(MediaMetadata::new_inherited(init)),
global,
proto,
can_gc,
)
}
/// <https://w3c.github.io/mediasession/#dom-mediametadata-mediametadata>
@ -53,9 +60,10 @@ impl MediaMetadata {
pub fn Constructor(
window: &Window,
proto: Option<HandleObject>,
can_gc: CanGc,
init: &MediaMetadataInit,
) -> Fallible<DomRoot<MediaMetadata>> {
Ok(MediaMetadata::new_with_proto(window, proto, init))
Ok(MediaMetadata::new_with_proto(window, proto, init, can_gc))
}
fn queue_update_metadata_algorithm(&self) {