Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-08 23:15:33 +01:00
Code Issues Projects Releases Packages Wiki Activity

Start marking functions that can transitively trigger a GC (#33144)

Browse source 
* Mark JS reflector wrappers as CanGc.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Propagate CanGc from reflect_dom_object_with_proto.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Mark DOM constructors as GC operations.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

---------

Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
Josh Matthews 2024-08-22 07:42:36 -04:00 • committed by GitHub
parent 9a1051c917
commit 60ef6bc461
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
140 changed files with 1336 additions and 304 deletions
Download patch file Download diff file Expand all files Collapse all files

18
components/script/dom/pagetransitionevent.rs
View file

@ -18,6 +18,7 @@ use crate::dom::bindings::root::DomRoot;
use crate::dom::bindings::str::DOMString;
use crate::dom::event::Event;
use crate::dom::window::Window;
use crate::script_runtime::CanGc;
// https://html.spec.whatwg.org/multipage/#pagetransitionevent
#[dom_struct]
@ -37,11 +38,13 @@ impl PageTransitionEvent {
fn new_uninitialized(
window: &Window,
proto: Option<HandleObject>,
can_gc: CanGc,
) -> DomRoot<PageTransitionEvent> {
reflect_dom_object_with_proto(
Box::new(PageTransitionEvent::new_inherited()),
window,
proto,
can_gc,
)
}
@ -52,7 +55,15 @@ impl PageTransitionEvent {
cancelable: bool,
persisted: bool,
) -> DomRoot<PageTransitionEvent> {
Self::new_with_proto(window, None, type_, bubbles, cancelable, persisted)
Self::new_with_proto(
window,
None,
type_,
bubbles,
cancelable,
persisted,
CanGc::note(),
)
}
fn new_with_proto(
@ -62,8 +73,9 @@ impl PageTransitionEvent {
bubbles: bool,
cancelable: bool,
persisted: bool,
can_gc: CanGc,
) -> DomRoot<PageTransitionEvent> {
let ev = PageTransitionEvent::new_uninitialized(window, proto);
let ev = PageTransitionEvent::new_uninitialized(window, proto, can_gc);
ev.persisted.set(persisted);
{
let event = ev.upcast::<Event>();
@ -76,6 +88,7 @@ impl PageTransitionEvent {
pub fn Constructor(
window: &Window,
proto: Option<HandleObject>,
can_gc: CanGc,
type_: DOMString,
init: &PageTransitionEventBinding::PageTransitionEventInit,
) -> Fallible<DomRoot<PageTransitionEvent>> {
@ -86,6 +99,7 @@ impl PageTransitionEvent {
init.parent.bubbles,
init.parent.cancelable,
init.persisted,
can_gc,
))
}
}