Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 22:15:33 +01:00
Code Issues Projects Releases Packages Wiki Activity

Start marking functions that can transitively trigger a GC (#33144)

Browse source 
* Mark JS reflector wrappers as CanGc.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Propagate CanGc from reflect_dom_object_with_proto.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Mark DOM constructors as GC operations.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

---------

Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
Josh Matthews 2024-08-22 07:42:36 -04:00 • committed by GitHub
parent 9a1051c917
commit 60ef6bc461
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
140 changed files with 1336 additions and 304 deletions
Download patch file Download diff file Expand all files Collapse all files

30
components/script/dom/popstateevent.rs
View file

@ -20,7 +20,7 @@ use crate::dom::bindings::trace::RootedTraceableBox;
use crate::dom::event::Event;
use crate::dom::eventtarget::EventTarget;
use crate::dom::window::Window;
use crate::script_runtime::JSContext;
use crate::script_runtime::{CanGc, JSContext};
// https://html.spec.whatwg.org/multipage/#the-popstateevent-interface
#[dom_struct]
@ -38,8 +38,17 @@ impl PopStateEvent {
}
}
fn new_uninitialized(window: &Window, proto: Option<HandleObject>) -> DomRoot<PopStateEvent> {
reflect_dom_object_with_proto(Box::new(PopStateEvent::new_inherited()), window, proto)
fn new_uninitialized(
window: &Window,
proto: Option<HandleObject>,
can_gc: CanGc,
) -> DomRoot<PopStateEvent> {
reflect_dom_object_with_proto(
Box::new(PopStateEvent::new_inherited()),
window,
proto,
can_gc,
)
}
fn new(
@ -49,8 +58,9 @@ impl PopStateEvent {
bubbles: bool,
cancelable: bool,
state: HandleValue,
can_gc: CanGc,
) -> DomRoot<PopStateEvent> {
let ev = PopStateEvent::new_uninitialized(window, proto);
let ev = PopStateEvent::new_uninitialized(window, proto, can_gc);
ev.state.set(state.get());
{
let event = ev.upcast::<Event>();
@ -63,6 +73,7 @@ impl PopStateEvent {
pub fn Constructor(
window: &Window,
proto: Option<HandleObject>,
can_gc: CanGc,
type_: DOMString,
init: RootedTraceableBox<PopStateEventBinding::PopStateEventInit>,
) -> Fallible<DomRoot<PopStateEvent>> {
@ -73,11 +84,20 @@ impl PopStateEvent {
init.parent.bubbles,
init.parent.cancelable,
init.state.handle(),
can_gc,
))
}
pub fn dispatch_jsval(target: &EventTarget, window: &Window, state: HandleValue) {
let event = PopStateEvent::new(window, None, atom!("popstate"), false, false, state);
let event = PopStateEvent::new(
window,
None,
atom!("popstate"),
false,
false,
state,
CanGc::note(),
);
event.upcast::<Event>().fire(target);
}
}