Start marking functions that can transitively trigger a GC (#33144)

* Mark JS reflector wrappers as CanGc.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Propagate CanGc from reflect_dom_object_with_proto.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Mark DOM constructors as GC operations.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

---------

Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
Josh Matthews 2024-08-22 07:42:36 -04:00 committed by GitHub
parent 9a1051c917
commit 60ef6bc461
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
140 changed files with 1336 additions and 304 deletions

View file

@ -16,6 +16,7 @@ use crate::dom::bindings::root::DomRoot;
use crate::dom::bindings::str::DOMString;
use crate::dom::event::{Event, EventBubbles, EventCancelable};
use crate::dom::globalscope::GlobalScope;
use crate::script_runtime::CanGc;
#[dom_struct]
pub struct ProgressEvent {
@ -53,6 +54,7 @@ impl ProgressEvent {
length_computable,
loaded,
total,
CanGc::note(),
)
}
@ -66,6 +68,7 @@ impl ProgressEvent {
length_computable: bool,
loaded: u64,
total: u64,
can_gc: CanGc,
) -> DomRoot<ProgressEvent> {
let ev = reflect_dom_object_with_proto(
Box::new(ProgressEvent::new_inherited(
@ -75,6 +78,7 @@ impl ProgressEvent {
)),
global,
proto,
can_gc,
);
{
let event = ev.upcast::<Event>();
@ -87,6 +91,7 @@ impl ProgressEvent {
pub fn Constructor(
global: &GlobalScope,
proto: Option<HandleObject>,
can_gc: CanGc,
type_: DOMString,
init: &ProgressEventBinding::ProgressEventInit,
) -> Fallible<DomRoot<ProgressEvent>> {
@ -101,6 +106,7 @@ impl ProgressEvent {
init.lengthComputable,
init.loaded,
init.total,
can_gc,
);
Ok(ev)
}