Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-15 10:25:32 +01:00
Code Issues Projects Releases Packages Wiki Activity

Start marking functions that can transitively trigger a GC (#33144)

Browse source 
* Mark JS reflector wrappers as CanGc.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Propagate CanGc from reflect_dom_object_with_proto.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Mark DOM constructors as GC operations.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

---------

Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
Josh Matthews 2024-08-22 07:42:36 -04:00 • committed by GitHub
parent 9a1051c917
commit 60ef6bc461
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
140 changed files with 1336 additions and 304 deletions
Download patch file Download diff file Expand all files Collapse all files

7
components/script/dom/promiserejectionevent.rs
View file

@ -23,7 +23,7 @@ use crate::dom::bindings::trace::RootedTraceableBox;
use crate::dom::event::{Event, EventBubbles, EventCancelable};
use crate::dom::globalscope::GlobalScope;
use crate::dom::promise::Promise;
use crate::script_runtime::JSContext;
use crate::script_runtime::{CanGc, JSContext};
#[dom_struct]
pub struct PromiseRejectionEvent {
@ -60,6 +60,7 @@ impl PromiseRejectionEvent {
cancelable,
promise.promise_obj(),
reason,
CanGc::note(),
)
}
@ -72,11 +73,13 @@ impl PromiseRejectionEvent {
cancelable: EventCancelable,
promise: HandleObject,
reason: HandleValue,
can_gc: CanGc,
) -> DomRoot<Self> {
let ev = reflect_dom_object_with_proto(
Box::new(PromiseRejectionEvent::new_inherited()),
global,
proto,
can_gc,
);
ev.promise.set(promise.get());
@ -93,6 +96,7 @@ impl PromiseRejectionEvent {
pub fn Constructor(
global: &GlobalScope,
proto: Option<HandleObject>,
can_gc: CanGc,
type_: DOMString,
init: RootedTraceableBox<PromiseRejectionEventBinding::PromiseRejectionEventInit>,
) -> Fallible<DomRoot<Self>> {
@ -108,6 +112,7 @@ impl PromiseRejectionEvent {
cancelable,
init.promise.handle(),
reason,
can_gc,
);
Ok(event)
}