mirror of
https://github.com/servo/servo.git
synced 2025-08-06 14:10:11 +01:00
Start marking functions that can transitively trigger a GC (#33144)
* Mark JS reflector wrappers as CanGc. Signed-off-by: Josh Matthews <josh@joshmatthews.net> * Propagate CanGc from reflect_dom_object_with_proto. Signed-off-by: Josh Matthews <josh@joshmatthews.net> * Mark DOM constructors as GC operations. Signed-off-by: Josh Matthews <josh@joshmatthews.net> --------- Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
parent
9a1051c917
commit
60ef6bc461
140 changed files with 1336 additions and 304 deletions
|
@ -24,6 +24,7 @@ use crate::dom::node::{window_from_node, Node};
|
|||
use crate::dom::resizeobserverentry::ResizeObserverEntry;
|
||||
use crate::dom::resizeobserversize::{ResizeObserverSize, ResizeObserverSizeImpl};
|
||||
use crate::dom::window::Window;
|
||||
use crate::script_runtime::CanGc;
|
||||
use crate::script_thread::ScriptThread;
|
||||
|
||||
/// <https://drafts.csswg.org/resize-observer/#calculate-depth-for-node>
|
||||
|
@ -61,9 +62,10 @@ impl ResizeObserver {
|
|||
window: &Window,
|
||||
proto: Option<HandleObject>,
|
||||
callback: Rc<ResizeObserverCallback>,
|
||||
can_gc: CanGc,
|
||||
) -> DomRoot<ResizeObserver> {
|
||||
let observer = Box::new(ResizeObserver::new_inherited(callback));
|
||||
reflect_dom_object_with_proto(observer, window, proto)
|
||||
reflect_dom_object_with_proto(observer, window, proto, can_gc)
|
||||
}
|
||||
|
||||
/// <https://drafts.csswg.org/resize-observer/#dom-resizeobserver-resizeobserver>
|
||||
|
@ -71,9 +73,10 @@ impl ResizeObserver {
|
|||
pub fn Constructor(
|
||||
window: &Window,
|
||||
proto: Option<HandleObject>,
|
||||
can_gc: CanGc,
|
||||
callback: Rc<ResizeObserverCallback>,
|
||||
) -> DomRoot<ResizeObserver> {
|
||||
let rooted_observer = ResizeObserver::new(window, proto, callback);
|
||||
let rooted_observer = ResizeObserver::new(window, proto, callback, can_gc);
|
||||
let document = window.Document();
|
||||
document.add_resize_observer(&rooted_observer);
|
||||
rooted_observer
|
||||
|
@ -128,6 +131,7 @@ impl ResizeObserver {
|
|||
box_size.origin.y.to_f64_px(),
|
||||
width,
|
||||
height,
|
||||
CanGc::note(),
|
||||
);
|
||||
let entry = ResizeObserverEntry::new(
|
||||
&window,
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue