Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-06-06 16:45:39 +00:00
Code Issues Projects Releases Packages Wiki Activity

Start marking functions that can transitively trigger a GC (#33144)

Browse source 
* Mark JS reflector wrappers as CanGc.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Propagate CanGc from reflect_dom_object_with_proto.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Mark DOM constructors as GC operations.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

---------

Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
Josh Matthews 2024-08-22 07:42:36 -04:00 • committed by GitHub
parent 9a1051c917
commit 60ef6bc461
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
140 changed files with 1336 additions and 304 deletions
Download patch file Download diff file Expand all files Collapse all files

6
components/script/dom/rtcicecandidate.rs
View file

@ -14,6 +14,7 @@ use crate::dom::bindings::root::DomRoot;
use crate::dom::bindings::str::DOMString;
use crate::dom::globalscope::GlobalScope;
use crate::dom::window::Window;
use crate::script_runtime::CanGc;
#[dom_struct]
pub struct RTCIceCandidate {
@ -54,6 +55,7 @@ impl RTCIceCandidate {
sdp_m_id,
sdp_m_line_index,
username_fragment,
CanGc::note(),
)
}
@ -64,6 +66,7 @@ impl RTCIceCandidate {
sdp_m_id: Option<DOMString>,
sdp_m_line_index: Option<u16>,
username_fragment: Option<DOMString>,
can_gc: CanGc,
) -> DomRoot<RTCIceCandidate> {
reflect_dom_object_with_proto(
Box::new(RTCIceCandidate::new_inherited(
@ -74,6 +77,7 @@ impl RTCIceCandidate {
)),
global,
proto,
can_gc,
)
}
@ -81,6 +85,7 @@ impl RTCIceCandidate {
pub fn Constructor(
window: &Window,
proto: Option<HandleObject>,
can_gc: CanGc,
config: &RTCIceCandidateInit,
) -> Fallible<DomRoot<RTCIceCandidate>> {
if config.sdpMid.is_none() && config.sdpMLineIndex.is_none() {
@ -95,6 +100,7 @@ impl RTCIceCandidate {
config.sdpMid.clone(),
config.sdpMLineIndex,
config.usernameFragment.clone(),
can_gc,
))
}
}