Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 14:10:11 +01:00
Code Issues Projects Releases Packages Wiki Activity

Start marking functions that can transitively trigger a GC (#33144)

Browse source 
* Mark JS reflector wrappers as CanGc.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Propagate CanGc from reflect_dom_object_with_proto.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Mark DOM constructors as GC operations.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

---------

Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
Josh Matthews 2024-08-22 07:42:36 -04:00 • committed by GitHub
parent 9a1051c917
commit 60ef6bc461
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
140 changed files with 1336 additions and 304 deletions
Download patch file Download diff file Expand all files Collapse all files

7
components/script/dom/rtcpeerconnectioniceevent.rs
View file

@ -19,6 +19,7 @@ use crate::dom::event::Event;
use crate::dom::globalscope::GlobalScope;
use crate::dom::rtcicecandidate::RTCIceCandidate;
use crate::dom::window::Window;
use crate::script_runtime::CanGc;
#[dom_struct]
pub struct RTCPeerConnectionIceEvent {
@ -46,7 +47,7 @@ impl RTCPeerConnectionIceEvent {
url: Option<DOMString>,
trusted: bool,
) -> DomRoot<RTCPeerConnectionIceEvent> {
Self::new_with_proto(global, None, ty, candidate, url, trusted)
Self::new_with_proto(global, None, ty, candidate, url, trusted, CanGc::note())
}
fn new_with_proto(
@ -56,11 +57,13 @@ impl RTCPeerConnectionIceEvent {
candidate: Option<&RTCIceCandidate>,
url: Option<DOMString>,
trusted: bool,
can_gc: CanGc,
) -> DomRoot<RTCPeerConnectionIceEvent> {
let e = reflect_dom_object_with_proto(
Box::new(RTCPeerConnectionIceEvent::new_inherited(candidate, url)),
global,
proto,
can_gc,
);
let evt = e.upcast::<Event>();
evt.init_event(ty, false, false); // XXXManishearth bubbles/cancelable?
@ -72,6 +75,7 @@ impl RTCPeerConnectionIceEvent {
pub fn Constructor(
window: &Window,
proto: Option<HandleObject>,
can_gc: CanGc,
ty: DOMString,
init: &RTCPeerConnectionIceEventInit,
) -> Fallible<DomRoot<RTCPeerConnectionIceEvent>> {
@ -85,6 +89,7 @@ impl RTCPeerConnectionIceEvent {
.map(|x| &**x),
init.url.as_ref().and_then(|x| x.clone()),
false,
can_gc,
))
}
}