Start marking functions that can transitively trigger a GC (#33144)

* Mark JS reflector wrappers as CanGc.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Propagate CanGc from reflect_dom_object_with_proto.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Mark DOM constructors as GC operations.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

---------

Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
Josh Matthews 2024-08-22 07:42:36 -04:00 committed by GitHub
parent 9a1051c917
commit 60ef6bc461
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
140 changed files with 1336 additions and 304 deletions

View file

@ -15,6 +15,7 @@ use crate::dom::bindings::root::DomRoot;
use crate::dom::document::Document;
use crate::dom::node::Node;
use crate::dom::window::Window;
use crate::script_runtime::CanGc;
#[dom_struct]
pub struct StaticRange {
@ -41,14 +42,16 @@ impl StaticRange {
document: &Document,
proto: Option<HandleObject>,
init: &StaticRangeInit,
can_gc: CanGc,
) -> DomRoot<StaticRange> {
StaticRange::new_with_proto(document, proto, init)
StaticRange::new_with_proto(document, proto, init, can_gc)
}
pub fn new_with_proto(
document: &Document,
proto: Option<HandleObject>,
init: &StaticRangeInit,
can_gc: CanGc,
) -> DomRoot<StaticRange> {
let staticrange = reflect_dom_object_with_proto(
Box::new(StaticRange::new_inherited(
@ -59,6 +62,7 @@ impl StaticRange {
)),
document.window(),
proto,
can_gc,
);
staticrange
}
@ -68,6 +72,7 @@ impl StaticRange {
pub fn Constructor(
window: &Window,
proto: Option<HandleObject>,
can_gc: CanGc,
init: &StaticRangeInit,
) -> Fallible<DomRoot<StaticRange>> {
match init.startContainer.type_id() {
@ -83,6 +88,6 @@ impl StaticRange {
_ => (),
}
let document = window.Document();
Ok(StaticRange::new_with_doc(&document, proto, init))
Ok(StaticRange::new_with_doc(&document, proto, init, can_gc))
}
}