Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 14:10:11 +01:00
Code Issues Projects Releases Packages Wiki Activity

Start marking functions that can transitively trigger a GC (#33144)

Browse source 
* Mark JS reflector wrappers as CanGc.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Propagate CanGc from reflect_dom_object_with_proto.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Mark DOM constructors as GC operations.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

---------

Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
Josh Matthews 2024-08-22 07:42:36 -04:00 • committed by GitHub
parent 9a1051c917
commit 60ef6bc461
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
140 changed files with 1336 additions and 304 deletions
Download patch file Download diff file Expand all files Collapse all files

10
components/script/dom/storageevent.rs
View file

@ -18,6 +18,7 @@ use crate::dom::bindings::str::{DOMString, USVString};
use crate::dom::event::{Event, EventBubbles, EventCancelable};
use crate::dom::storage::Storage;
use crate::dom::window::Window;
use crate::script_runtime::CanGc;
#[dom_struct]
pub struct StorageEvent {
@ -49,18 +50,20 @@ impl StorageEvent {
}
pub fn new_uninitialized(window: &Window, url: DOMString) -> DomRoot<StorageEvent> {
Self::new_uninitialized_with_proto(window, None, url)
Self::new_uninitialized_with_proto(window, None, url, CanGc::note())
}
fn new_uninitialized_with_proto(
window: &Window,
proto: Option<HandleObject>,
url: DOMString,
can_gc: CanGc,
) -> DomRoot<StorageEvent> {
reflect_dom_object_with_proto(
Box::new(StorageEvent::new_inherited(None, None, None, url, None)),
window,
proto,
can_gc,
)
}
@ -87,6 +90,7 @@ impl StorageEvent {
newValue,
url,
storageArea,
CanGc::note(),
)
}
@ -102,6 +106,7 @@ impl StorageEvent {
newValue: Option<DOMString>,
url: DOMString,
storageArea: Option<&Storage>,
can_gc: CanGc,
) -> DomRoot<StorageEvent> {
let ev = reflect_dom_object_with_proto(
Box::new(StorageEvent::new_inherited(
@ -113,6 +118,7 @@ impl StorageEvent {
)),
global,
proto,
can_gc,
);
{
let event = ev.upcast::<Event>();
@ -124,6 +130,7 @@ impl StorageEvent {
pub fn Constructor(
global: &Window,
proto: Option<HandleObject>,
can_gc: CanGc,
type_: DOMString,
init: &StorageEventBinding::StorageEventInit,
) -> Fallible<DomRoot<StorageEvent>> {
@ -145,6 +152,7 @@ impl StorageEvent {
newValue,
url,
storageArea,
can_gc,
);
Ok(event)
}