Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-30 00:29:14 +01:00
Code Issues Projects Releases Packages Wiki Activity

Start marking functions that can transitively trigger a GC (#33144)

Browse source 
* Mark JS reflector wrappers as CanGc.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Propagate CanGc from reflect_dom_object_with_proto.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Mark DOM constructors as GC operations.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

---------

Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
Josh Matthews 2024-08-22 07:42:36 -04:00 • committed by GitHub
parent 9a1051c917
commit 60ef6bc461
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
140 changed files with 1336 additions and 304 deletions
Download patch file Download diff file Expand all files Collapse all files

15
components/script/dom/submitevent.rs
View file

@ -17,6 +17,7 @@ use crate::dom::event::Event;
use crate::dom::globalscope::GlobalScope;
use crate::dom::htmlelement::HTMLElement;
use crate::dom::window::Window;
use crate::script_runtime::CanGc;
#[dom_struct]
#[allow(non_snake_case)]
@ -40,7 +41,15 @@ impl SubmitEvent {
cancelable: bool,
submitter: Option<DomRoot<HTMLElement>>,
) -> DomRoot<SubmitEvent> {
Self::new_with_proto(global, None, type_, bubbles, cancelable, submitter)
Self::new_with_proto(
global,
None,
type_,
bubbles,
cancelable,
submitter,
CanGc::note(),
)
}
fn new_with_proto(
@ -50,11 +59,13 @@ impl SubmitEvent {
bubbles: bool,
cancelable: bool,
submitter: Option<DomRoot<HTMLElement>>,
can_gc: CanGc,
) -> DomRoot<SubmitEvent> {
let ev = reflect_dom_object_with_proto(
Box::new(SubmitEvent::new_inherited(submitter)),
global,
proto,
can_gc,
);
{
let event = ev.upcast::<Event>();
@ -67,6 +78,7 @@ impl SubmitEvent {
pub fn Constructor(
window: &Window,
proto: Option<HandleObject>,
can_gc: CanGc,
type_: DOMString,
init: &SubmitEventBinding::SubmitEventInit,
) -> DomRoot<SubmitEvent> {
@ -77,6 +89,7 @@ impl SubmitEvent {
init.parent.bubbles,
init.parent.cancelable,
init.submitter.as_ref().map(|s| DomRoot::from_ref(&**s)),
can_gc,
)
}
}