Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 20:50:07 +01:00
Code Issues Projects Releases Packages Wiki Activity

Start marking functions that can transitively trigger a GC (#33144)

Browse source 
* Mark JS reflector wrappers as CanGc.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Propagate CanGc from reflect_dom_object_with_proto.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Mark DOM constructors as GC operations.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

---------

Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
Josh Matthews 2024-08-22 07:42:36 -04:00 • committed by GitHub
parent 9a1051c917
commit 60ef6bc461
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
140 changed files with 1336 additions and 304 deletions
Download patch file Download diff file Expand all files Collapse all files

24
components/script/dom/testbinding.rs
View file

@ -49,7 +49,7 @@ use crate::dom::promise::Promise;
use crate::dom::promisenativehandler::{Callback, PromiseNativeHandler};
use crate::dom::url::URL;
use crate::realms::InRealm;
use crate::script_runtime::JSContext as SafeJSContext;
use crate::script_runtime::{CanGc, JSContext as SafeJSContext};
use crate::timers::OneshotTimerCallback;
#[dom_struct]
@ -67,33 +67,45 @@ impl TestBinding {
}
}
fn new(global: &GlobalScope, proto: Option<HandleObject>) -> DomRoot<TestBinding> {
reflect_dom_object_with_proto(Box::new(TestBinding::new_inherited()), global, proto)
fn new(
global: &GlobalScope,
proto: Option<HandleObject>,
can_gc: CanGc,
) -> DomRoot<TestBinding> {
reflect_dom_object_with_proto(
Box::new(TestBinding::new_inherited()),
global,
proto,
can_gc,
)
}
pub fn Constructor(
global: &GlobalScope,
proto: Option<HandleObject>,
can_gc: CanGc,
) -> Fallible<DomRoot<TestBinding>> {
Ok(TestBinding::new(global, proto))
Ok(TestBinding::new(global, proto, can_gc))
}
#[allow(unused_variables)]
pub fn Constructor_(
global: &GlobalScope,
proto: Option<HandleObject>,
can_gc: CanGc,
nums: Vec<f64>,
) -> Fallible<DomRoot<TestBinding>> {
Ok(TestBinding::new(global, proto))
Ok(TestBinding::new(global, proto, can_gc))
}
#[allow(unused_variables)]
pub fn Constructor__(
global: &GlobalScope,
proto: Option<HandleObject>,
can_gc: CanGc,
num: f64,
) -> Fallible<DomRoot<TestBinding>> {
Ok(TestBinding::new(global, proto))
Ok(TestBinding::new(global, proto, can_gc))
}
}