Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 14:10:11 +01:00
Code Issues Projects Releases Packages Wiki Activity

Start marking functions that can transitively trigger a GC (#33144)

Browse source 
* Mark JS reflector wrappers as CanGc.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Propagate CanGc from reflect_dom_object_with_proto.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Mark DOM constructors as GC operations.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

---------

Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
Josh Matthews 2024-08-22 07:42:36 -04:00 • committed by GitHub
parent 9a1051c917
commit 60ef6bc461
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
140 changed files with 1336 additions and 304 deletions
Download patch file Download diff file Expand all files Collapse all files

18
components/script/dom/textencoder.rs
View file

@ -16,7 +16,7 @@ use crate::dom::bindings::reflector::{reflect_dom_object_with_proto, Reflector};
use crate::dom::bindings::root::DomRoot;
use crate::dom::bindings::str::{DOMString, USVString};
use crate::dom::globalscope::GlobalScope;
use crate::script_runtime::JSContext;
use crate::script_runtime::{CanGc, JSContext};
#[dom_struct]
pub struct TextEncoder {
@ -30,8 +30,17 @@ impl TextEncoder {
}
}
fn new(global: &GlobalScope, proto: Option<HandleObject>) -> DomRoot<TextEncoder> {
reflect_dom_object_with_proto(Box::new(TextEncoder::new_inherited()), global, proto)
fn new(
global: &GlobalScope,
proto: Option<HandleObject>,
can_gc: CanGc,
) -> DomRoot<TextEncoder> {
reflect_dom_object_with_proto(
Box::new(TextEncoder::new_inherited()),
global,
proto,
can_gc,
)
}
// https://encoding.spec.whatwg.org/#dom-textencoder
@ -39,8 +48,9 @@ impl TextEncoder {
pub fn Constructor(
global: &GlobalScope,
proto: Option<HandleObject>,
can_gc: CanGc,
) -> Fallible<DomRoot<TextEncoder>> {
Ok(TextEncoder::new(global, proto))
Ok(TextEncoder::new(global, proto, can_gc))
}
}