Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 14:10:11 +01:00
Code Issues Projects Releases Packages Wiki Activity

Start marking functions that can transitively trigger a GC (#33144)

Browse source 
* Mark JS reflector wrappers as CanGc.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Propagate CanGc from reflect_dom_object_with_proto.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Mark DOM constructors as GC operations.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

---------

Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
Josh Matthews 2024-08-22 07:42:36 -04:00 • committed by GitHub
parent 9a1051c917
commit 60ef6bc461
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
140 changed files with 1336 additions and 304 deletions
Download patch file Download diff file Expand all files Collapse all files

7
components/script/dom/transitionevent.rs
View file

@ -18,6 +18,7 @@ use crate::dom::bindings::root::DomRoot;
use crate::dom::bindings::str::DOMString;
use crate::dom::event::Event;
use crate::dom::window::Window;
use crate::script_runtime::CanGc;
#[dom_struct]
pub struct TransitionEvent {
@ -43,7 +44,7 @@ impl TransitionEvent {
type_: Atom,
init: &TransitionEventInit,
) -> DomRoot<TransitionEvent> {
Self::new_with_proto(window, None, type_, init)
Self::new_with_proto(window, None, type_, init, CanGc::note())
}
fn new_with_proto(
@ -51,11 +52,13 @@ impl TransitionEvent {
proto: Option<HandleObject>,
type_: Atom,
init: &TransitionEventInit,
can_gc: CanGc,
) -> DomRoot<TransitionEvent> {
let ev = reflect_dom_object_with_proto(
Box::new(TransitionEvent::new_inherited(init)),
window,
proto,
can_gc,
);
{
let event = ev.upcast::<Event>();
@ -68,6 +71,7 @@ impl TransitionEvent {
pub fn Constructor(
window: &Window,
proto: Option<HandleObject>,
can_gc: CanGc,
type_: DOMString,
init: &TransitionEventInit,
) -> Fallible<DomRoot<TransitionEvent>> {
@ -76,6 +80,7 @@ impl TransitionEvent {
proto,
Atom::from(type_),
init,
can_gc,
))
}
}