Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 04:30:10 +01:00
Code Issues Projects Releases Packages Wiki Activity

Start marking functions that can transitively trigger a GC (#33144)

Browse source 
* Mark JS reflector wrappers as CanGc.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Propagate CanGc from reflect_dom_object_with_proto.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Mark DOM constructors as GC operations.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

---------

Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
Josh Matthews 2024-08-22 07:42:36 -04:00 • committed by GitHub
parent 9a1051c917
commit 60ef6bc461
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
140 changed files with 1336 additions and 304 deletions
Download patch file Download diff file Expand all files Collapse all files

14
components/script/dom/urlsearchparams.rs
View file

@ -17,6 +17,7 @@ use crate::dom::bindings::str::{DOMString, USVString};
use crate::dom::bindings::weakref::MutableWeakRef;
use crate::dom::globalscope::GlobalScope;
use crate::dom::url::URL;
use crate::script_runtime::CanGc;
/// <https://url.spec.whatwg.org/#interface-urlsearchparams>
#[dom_struct]
@ -38,15 +39,21 @@ impl URLSearchParams {
}
pub fn new(global: &GlobalScope, url: Option<&URL>) -> DomRoot<URLSearchParams> {
Self::new_with_proto(global, None, url)
Self::new_with_proto(global, None, url, CanGc::note())
}
pub fn new_with_proto(
global: &GlobalScope,
proto: Option<HandleObject>,
url: Option<&URL>,
can_gc: CanGc,
) -> DomRoot<URLSearchParams> {
reflect_dom_object_with_proto(Box::new(URLSearchParams::new_inherited(url)), global, proto)
reflect_dom_object_with_proto(
Box::new(URLSearchParams::new_inherited(url)),
global,
proto,
can_gc,
)
}
/// <https://url.spec.whatwg.org/#dom-urlsearchparams-urlsearchparams>
@ -54,10 +61,11 @@ impl URLSearchParams {
pub fn Constructor(
global: &GlobalScope,
proto: Option<HandleObject>,
can_gc: CanGc,
init: USVStringSequenceSequenceOrUSVStringUSVStringRecordOrUSVString,
) -> Fallible<DomRoot<URLSearchParams>> {
// Step 1.
let query = URLSearchParams::new_with_proto(global, proto, None);
let query = URLSearchParams::new_with_proto(global, proto, None, can_gc);
match init {
USVStringSequenceSequenceOrUSVStringUSVStringRecordOrUSVString::USVStringSequenceSequence(init) => {
// Step 2.