Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 04:30:10 +01:00
Code Issues Projects Releases Packages Wiki Activity

Start marking functions that can transitively trigger a GC (#33144)

Browse source 
* Mark JS reflector wrappers as CanGc.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Propagate CanGc from reflect_dom_object_with_proto.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Mark DOM constructors as GC operations.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

---------

Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
Josh Matthews 2024-08-22 07:42:36 -04:00 • committed by GitHub
parent 9a1051c917
commit 60ef6bc461
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
140 changed files with 1336 additions and 304 deletions
Download patch file Download diff file Expand all files Collapse all files

26
components/script/dom/wheelevent.rs
View file

@ -19,6 +19,7 @@ use crate::dom::bindings::str::DOMString;
use crate::dom::event::{Event, EventBubbles, EventCancelable};
use crate::dom::mouseevent::MouseEvent;
use crate::dom::window::Window;
use crate::script_runtime::CanGc;
#[dom_struct]
pub struct WheelEvent {
@ -40,8 +41,12 @@ impl WheelEvent {
}
}
fn new_unintialized(window: &Window, proto: Option<HandleObject>) -> DomRoot<WheelEvent> {
reflect_dom_object_with_proto(Box::new(WheelEvent::new_inherited()), window, proto)
fn new_unintialized(
window: &Window,
proto: Option<HandleObject>,
can_gc: CanGc,
) -> DomRoot<WheelEvent> {
reflect_dom_object_with_proto(Box::new(WheelEvent::new_inherited()), window, proto, can_gc)
}
#[allow(clippy::too_many_arguments)]
@ -58,8 +63,18 @@ impl WheelEvent {
delta_mode: u32,
) -> DomRoot<WheelEvent> {
Self::new_with_proto(
window, None, type_, can_bubble, cancelable, view, detail, delta_x, delta_y, delta_z,
window,
None,
type_,
can_bubble,
cancelable,
view,
detail,
delta_x,
delta_y,
delta_z,
delta_mode,
CanGc::note(),
)
}
@ -76,8 +91,9 @@ impl WheelEvent {
delta_y: Finite<f64>,
delta_z: Finite<f64>,
delta_mode: u32,
can_gc: CanGc,
) -> DomRoot<WheelEvent> {
let ev = WheelEvent::new_unintialized(window, proto);
let ev = WheelEvent::new_unintialized(window, proto, can_gc);
ev.InitWheelEvent(
type_,
bool::from(can_bubble),
@ -97,6 +113,7 @@ impl WheelEvent {
pub fn Constructor(
window: &Window,
proto: Option<HandleObject>,
can_gc: CanGc,
type_: DOMString,
init: &WheelEventBinding::WheelEventInit,
) -> Fallible<DomRoot<WheelEvent>> {
@ -112,6 +129,7 @@ impl WheelEvent {
init.deltaY,
init.deltaZ,
init.deltaMode,
can_gc,
);
Ok(event)