Start marking functions that can transitively trigger a GC (#33144)

* Mark JS reflector wrappers as CanGc.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Propagate CanGc from reflect_dom_object_with_proto.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Mark DOM constructors as GC operations.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

---------

Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
Josh Matthews 2024-08-22 07:42:36 -04:00 committed by GitHub
parent 9a1051c917
commit 60ef6bc461
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
140 changed files with 1336 additions and 304 deletions

View file

@ -13,6 +13,7 @@ use crate::dom::bindings::root::{Dom, DomRoot};
use crate::dom::bindings::str::DOMString;
use crate::dom::node::Node;
use crate::dom::window::Window;
use crate::script_runtime::CanGc;
#[dom_struct]
pub struct XMLSerializer {
@ -28,11 +29,16 @@ impl XMLSerializer {
}
}
pub fn new(window: &Window, proto: Option<HandleObject>) -> DomRoot<XMLSerializer> {
pub fn new(
window: &Window,
proto: Option<HandleObject>,
can_gc: CanGc,
) -> DomRoot<XMLSerializer> {
reflect_dom_object_with_proto(
Box::new(XMLSerializer::new_inherited(window)),
window,
proto,
can_gc,
)
}
@ -40,8 +46,9 @@ impl XMLSerializer {
pub fn Constructor(
window: &Window,
proto: Option<HandleObject>,
can_gc: CanGc,
) -> Fallible<DomRoot<XMLSerializer>> {
Ok(XMLSerializer::new(window, proto))
Ok(XMLSerializer::new(window, proto, can_gc))
}
}