Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-07 06:25:32 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #14341 - stshine:where-is-the-top, r=mrobinson,emilio

Browse source 
script: Fix the scroll to top behavior

<!-- Please describe your changes on the following line: -->

When finding the indicated fragment, do not use the document element to indicate
the top of the Document, and when scrolling to the frament and we do not find a
element, scrolling the top if the fragment is empty or equal to "top".

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14341)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2016-11-23 21:51:20 -08:00 • committed by GitHub
commit 61a225bab0
3 changed files with 54 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

6
tests/wpt/mozilla/meta/MANIFEST.json
View file

@ -14810,6 +14810,12 @@
"url": "/_mozilla/mozilla/scrollTo.html"
}
],
"mozilla/scroll_top_null_target.html": [
{
"path": "mozilla/scroll_top_null_target.html",
"url": "/_mozilla/mozilla/scroll_top_null_target.html"
}
],
"mozilla/send-arraybuffer.htm": [
{
"path": "mozilla/send-arraybuffer.htm",

21
tests/wpt/mozilla/tests/mozilla/scroll_top_null_target.html Normal file
View file

@ -0,0 +1,21 @@
<!doctype html>
<html>
<head>
<meta charset="utf-8">
<title></title>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
</head>
<body>
<a id="test"></a>
</body>
<script>
test(function() {
location.hash = "test";
assert_equals(document.querySelector(":target"), document.getElementById("test"),
"Target shoud be the same with the test anchor!");
location.hash = "";
assert_equals(document.querySelector(":target"), null, "Target should be null!");
});
</script>
</html>