Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-06-13 19:04:30 +00:00
Code Issues Projects Releases Packages Wiki Activity

Make errors during build status notification warnings

Browse source 
Instead of raising an exception, simply print a warning on stderr when
notification fails.

Fixes #29635.
This commit is contained in:
Martin Robinson 2023-04-17 09:03:01 +02:00
parent 6e2615f0b5
commit 61a70fbff2
1 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
python/servo/build_commands.py
View file

@ -744,12 +744,15 @@ class MachCommands(CommandBase):
-1 # timeout -1 # timeout
) )
except ImportError: except ImportError:
raise Exception("Optional Python module 'dbus' is not installed.") print("[Warning] Could not generate notification: "
"Optional Python module 'dbus' is not installed.",
file=sys.stderr)
return True return True
if notify_command: if notify_command:
if call([notify_command, title, message]) != 0: if call([notify_command, title, message]) != 0:
raise Exception("Could not run '%s'." % notify_command) print("[Warning] Could not generate notification: "
f"Could not run '{notify_command}'.", file=sys.stderr)
else: else:
notifier = LinuxNotifier if sys.platform.startswith("linux") else None notifier = LinuxNotifier if sys.platform.startswith("linux") else None
notification = notifypy.Notify(use_custom_notifier=notifier) notification = notifypy.Notify(use_custom_notifier=notifier)