Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 14:10:11 +01:00
Code Issues Projects Releases Packages Wiki Activity

Enable new color functions from CSS Color 4 (#30752)

Browse source 
I will need to do most of the work anyways during the style updates,
so by enabling this it will be easier to detect mistakes.

Also, canvas colors are now parsed as <color>, precisely to support
these new features. This is according to the HTML spec:
https://html.spec.whatwg.org/multipage/infrastructure.html#parsed-as-a-css-color-value
This commit is contained in:
Oriol Brufau 2023-11-20 17:15:43 +01:00 • committed by GitHub
parent 868d84d8ee
commit 61af8fb56d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
220 changed files with 75 additions and 4283 deletions
Download patch file Download diff file Expand all files Collapse all files

16
components/script/dom/canvasgradient.rs
View file

@ -5,9 +5,9 @@
use canvas_traits::canvas::{
CanvasGradientStop, FillOrStrokeStyle, LinearGradientStyle, RadialGradientStyle,
};
use cssparser::{Color as CSSColor, Parser, ParserInput, RGBA};
use dom_struct::dom_struct;
use crate::canvas_state::parse_color;
use crate::dom::bindings::cell::DomRefCell;
use crate::dom::bindings::codegen::Bindings::CanvasRenderingContext2DBinding::CanvasGradientMethods;
use crate::dom::bindings::error::{Error, ErrorResult};
@ -53,17 +53,9 @@ impl CanvasGradientMethods for CanvasGradient {
return Err(Error::IndexSize);
}
let mut input = ParserInput::new(&color);
let mut parser = Parser::new(&mut input);
let color = CSSColor::parse(&mut parser);
let color = if parser.is_exhausted() {
match color {
Ok(CSSColor::Rgba(rgba)) => rgba,
Ok(CSSColor::CurrentColor) => RGBA::new(0, 0, 0, 1.0),
_ => return Err(Error::Syntax),
}
} else {
return Err(Error::Syntax);
let color = match parse_color(None, &color) {
Ok(color) => color,
Err(_) => return Err(Error::Syntax),
};
self.stops.borrow_mut().push(CanvasGradientStop {