Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-07 14:35:33 +01:00
Code Issues Projects Releases Packages Wiki Activity

Accept only connected attributes for checkbox and radio activation behaviour

Browse source
This commit is contained in:
Dmitry Kolupaev 2020-03-10 00:07:00 +03:00
parent 4b1bb895a3
commit 6284795078
2 changed files with 3 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

3
components/script/dom/htmlinputelement.rs
View file

@ -2488,6 +2488,9 @@ impl Activatable for HTMLInputElement {
// https://html.spec.whatwg.org/multipage/#checkbox-state-(type=checkbox):activation-behavior // https://html.spec.whatwg.org/multipage/#checkbox-state-(type=checkbox):activation-behavior
// https://html.spec.whatwg.org/multipage/#radio-button-state-(type=radio):activation-behavior // https://html.spec.whatwg.org/multipage/#radio-button-state-(type=radio):activation-behavior
// Check if document owner is fully active // Check if document owner is fully active
if !self.upcast::<Node>().is_connected() {
return ();
}
let target = self.upcast::<EventTarget>(); let target = self.upcast::<EventTarget>();
target.fire_bubbling_event(atom!("input")); target.fire_bubbling_event(atom!("input"));
target.fire_bubbling_event(atom!("change")); target.fire_bubbling_event(atom!("change"));

12
tests/wpt/metadata/dom/events/Event-dispatch-detached-input-and-change.html.ini
View file

@ -2,21 +2,9 @@
[attached to shadow dom radio should emit input and change events on click().] [attached to shadow dom radio should emit input and change events on click().]
expected: FAIL expected: FAIL
[detached checkbox should not emit input or change events on click().]
expected: FAIL
[attached to shadow dom checkbox should emit input and change events on click().] [attached to shadow dom checkbox should emit input and change events on click().]
expected: FAIL expected: FAIL
[detached radio should not emit input or change events on click().]
expected: FAIL
[detached radio should not emit input or change events on dispatchEvent(new MouseEvent('click')).]
expected: FAIL
[detached checkbox should not emit input or change events on dispatchEvent(new MouseEvent('click')).]
expected: FAIL
[attached to shadow dom checkbox should emit input and change events on dispatchEvent(new MouseEvent('click')).] [attached to shadow dom checkbox should emit input and change events on dispatchEvent(new MouseEvent('click')).]
expected: FAIL expected: FAIL