Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-30 00:29:14 +01:00
Code Issues Projects Releases Packages Wiki Activity

script: Measure heap usage of various ignored fields (#38791)

Browse source 
These changes allow using MallocSizeOf/`#[conditional_malloc_size_of]`
on WebIDL callback values, and then fix a grab bag of places in the
script crate that previously ignored those values. There are also some
commits removing ignored fields that involved Arc/Rc that are not WebIDL
callbacks, since they are now easier to support with the
`#[conditional_malloc_size_of]` attribute.

Testing: Manual testing on about:memory for servo.org.

---------

Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
Josh Matthews 2025-08-20 04:43:58 -04:00 • committed by GitHub
parent 604b6ea26d
commit 636e7211e0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
16 changed files with 44 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

4
components/script/microtask.rs
View file

@ -55,7 +55,7 @@ pub(crate) trait MicrotaskRunnable {
/// A promise callback scheduled to run during the next microtask checkpoint (#4283).
#[derive(JSTraceable, MallocSizeOf)]
pub(crate) struct EnqueuedPromiseCallback {
#[ignore_malloc_size_of = "Rc has unclear ownership"]
#[conditional_malloc_size_of]
pub(crate) callback: Rc<PromiseJobCallback>,
#[no_trace]
pub(crate) pipeline: PipelineId,
@ -66,7 +66,7 @@ pub(crate) struct EnqueuedPromiseCallback {
/// identical to EnqueuedPromiseCallback once it's on the queue
#[derive(JSTraceable, MallocSizeOf)]
pub(crate) struct UserMicrotask {
#[ignore_malloc_size_of = "Rc has unclear ownership"]
#[conditional_malloc_size_of]
pub(crate) callback: Rc<VoidFunction>,
#[no_trace]
pub(crate) pipeline: PipelineId,