From 94a7563aea56ac560d5b0cb0afef1418d242a646 Mon Sep 17 00:00:00 2001 From: Matt Brubeck Date: Wed, 18 Mar 2015 17:17:33 -0700 Subject: [PATCH] Use `append` instead of `extend` where possible The new `Vec::append` method is clearer and potentially faster. --- components/layout/inline.rs | 4 ++-- tests/reftest.rs | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/components/layout/inline.rs b/components/layout/inline.rs index 97d88bb06b2..91358eed717 100644 --- a/components/layout/inline.rs +++ b/components/layout/inline.rs @@ -743,8 +743,8 @@ impl InlineFragments { } /// Merges another set of inline fragments with this one. - pub fn push_all(&mut self, fragments: InlineFragments) { - self.fragments.extend(fragments.fragments.into_iter()); + pub fn push_all(&mut self, mut other: InlineFragments) { + self.fragments.append(&mut other.fragments); } /// A convenience function to return the fragment at a given index. diff --git a/tests/reftest.rs b/tests/reftest.rs index d8a98784a29..978a8f45318 100644 --- a/tests/reftest.rs +++ b/tests/reftest.rs @@ -73,9 +73,9 @@ fn main() { match maybe_extension { Some(extension) => { if extension.to_ascii_lowercase().as_slice() == "list" && file.is_file() { - let tests = parse_lists(&file, servo_args, render_mode, all_tests.len()); + let mut tests = parse_lists(&file, servo_args, render_mode, all_tests.len()); println!("\t{} [{} tests]", file.display(), tests.len()); - all_tests.extend(tests.into_iter()); + all_tests.append(&mut tests); } } _ => {}