Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 21:50:18 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #9800 - Wafflespeanut:node_attrs, r=nox

Browse source 
fixed the last failing test in dom/nodes/attributes.html

r? @nox

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9800)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2016-03-05 21:32:46 +05:30
commit 64fb09ca2d
2 changed files with 14 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

17
components/script/dom/namednodemap.rs
View file

@ -13,6 +13,7 @@ use dom::bindings::reflector::{Reflector, reflect_dom_object};
use dom::bindings::xmlname::namespace_from_domstring;
use dom::element::Element;
use dom::window::Window;
use std::ascii::AsciiExt;
use string_cache::Atom;
use util::str::DOMString;
@ -99,8 +100,18 @@ impl NamedNodeMapMethods for NamedNodeMap {
// https://heycam.github.io/webidl/#dfn-supported-property-names
fn SupportedPropertyNames(&self) -> Vec<DOMString> {
self.owner.attrs().iter().map(|attr| {
DOMString::from(&**attr.name()) // FIXME(ajeffrey): Convert directly from &Atom to DOMString
}).collect()
let mut names = vec!();
let html_element_in_html_document = self.owner.html_element_in_html_document();
for attr in self.owner.attrs().iter() {
let s = &**attr.name();
if html_element_in_html_document && !s.bytes().all(|b| b.to_ascii_lowercase() == b) {
continue
}
if !names.iter().any(|name| &*name == s) {
names.push(DOMString::from(s));
}
}
names
}
}