mirror of
https://github.com/servo/servo.git
synced 2025-08-07 06:25:32 +01:00
stylo: Add glue for contain property
This commit is contained in:
parent
fe47726b7c
commit
65b6a89978
3 changed files with 75 additions and 25 deletions
|
@ -1641,7 +1641,7 @@ fn static_assert() {
|
||||||
scroll-snap-points-x scroll-snap-points-y transform
|
scroll-snap-points-x scroll-snap-points-y transform
|
||||||
scroll-snap-type-y scroll-snap-coordinate
|
scroll-snap-type-y scroll-snap-coordinate
|
||||||
perspective-origin transform-origin -moz-binding will-change
|
perspective-origin transform-origin -moz-binding will-change
|
||||||
shape-outside""" %>
|
shape-outside contain""" %>
|
||||||
<%self:impl_trait style_struct_name="Box" skip_longhands="${skip_box_longhands}">
|
<%self:impl_trait style_struct_name="Box" skip_longhands="${skip_box_longhands}">
|
||||||
|
|
||||||
// We manually-implement the |display| property until we get general
|
// We manually-implement the |display| property until we get general
|
||||||
|
@ -2257,6 +2257,71 @@ fn static_assert() {
|
||||||
}
|
}
|
||||||
|
|
||||||
<% impl_shape_source("shape_outside", "mShapeOutside") %>
|
<% impl_shape_source("shape_outside", "mShapeOutside") %>
|
||||||
|
|
||||||
|
pub fn set_contain(&mut self, v: longhands::contain::computed_value::T) {
|
||||||
|
use gecko_bindings::structs::NS_STYLE_CONTAIN_NONE;
|
||||||
|
use gecko_bindings::structs::NS_STYLE_CONTAIN_STRICT;
|
||||||
|
use gecko_bindings::structs::NS_STYLE_CONTAIN_LAYOUT;
|
||||||
|
use gecko_bindings::structs::NS_STYLE_CONTAIN_STYLE;
|
||||||
|
use gecko_bindings::structs::NS_STYLE_CONTAIN_PAINT;
|
||||||
|
use gecko_bindings::structs::NS_STYLE_CONTAIN_ALL_BITS;
|
||||||
|
use properties::longhands::contain;
|
||||||
|
|
||||||
|
if v.is_empty() {
|
||||||
|
self.gecko.mContain = NS_STYLE_CONTAIN_NONE as u8;
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
if v.contains(contain::STRICT) {
|
||||||
|
self.gecko.mContain = (NS_STYLE_CONTAIN_STRICT | NS_STYLE_CONTAIN_ALL_BITS) as u8;
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
let mut bitfield = 0;
|
||||||
|
if v.contains(contain::LAYOUT) {
|
||||||
|
bitfield |= NS_STYLE_CONTAIN_LAYOUT;
|
||||||
|
}
|
||||||
|
if v.contains(contain::STYLE) {
|
||||||
|
bitfield |= NS_STYLE_CONTAIN_STYLE;
|
||||||
|
}
|
||||||
|
if v.contains(contain::PAINT) {
|
||||||
|
bitfield |= NS_STYLE_CONTAIN_PAINT;
|
||||||
|
}
|
||||||
|
|
||||||
|
self.gecko.mContain = bitfield as u8;
|
||||||
|
}
|
||||||
|
|
||||||
|
pub fn clone_contain(&self) -> longhands::contain::computed_value::T {
|
||||||
|
use gecko_bindings::structs::NS_STYLE_CONTAIN_STRICT;
|
||||||
|
use gecko_bindings::structs::NS_STYLE_CONTAIN_LAYOUT;
|
||||||
|
use gecko_bindings::structs::NS_STYLE_CONTAIN_STYLE;
|
||||||
|
use gecko_bindings::structs::NS_STYLE_CONTAIN_PAINT;
|
||||||
|
use gecko_bindings::structs::NS_STYLE_CONTAIN_ALL_BITS;
|
||||||
|
use properties::longhands::contain;
|
||||||
|
|
||||||
|
let mut servo_flags = contain::computed_value::T::empty();
|
||||||
|
let gecko_flags = self.gecko.mContain;
|
||||||
|
|
||||||
|
if gecko_flags & (NS_STYLE_CONTAIN_STRICT as u8) != 0 &&
|
||||||
|
gecko_flags & (NS_STYLE_CONTAIN_ALL_BITS as u8) != 0 {
|
||||||
|
servo_flags.insert(contain::STRICT | contain::STRICT_BITS);
|
||||||
|
return servo_flags;
|
||||||
|
}
|
||||||
|
|
||||||
|
if gecko_flags & (NS_STYLE_CONTAIN_LAYOUT as u8) != 0 {
|
||||||
|
servo_flags.insert(contain::LAYOUT);
|
||||||
|
}
|
||||||
|
if gecko_flags & (NS_STYLE_CONTAIN_STYLE as u8) != 0{
|
||||||
|
servo_flags.insert(contain::STYLE);
|
||||||
|
}
|
||||||
|
if gecko_flags & (NS_STYLE_CONTAIN_PAINT as u8) != 0 {
|
||||||
|
servo_flags.insert(contain::PAINT);
|
||||||
|
}
|
||||||
|
|
||||||
|
return servo_flags;
|
||||||
|
}
|
||||||
|
|
||||||
|
${impl_simple_copy("contain", "mContain")}
|
||||||
</%self:impl_trait>
|
</%self:impl_trait>
|
||||||
|
|
||||||
<%def name="simple_image_array_property(name, shorthand, field_name)">
|
<%def name="simple_image_array_property(name, shorthand, field_name)">
|
||||||
|
|
|
@ -2076,7 +2076,10 @@ ${helpers.single_keyword("transform-style",
|
||||||
}
|
}
|
||||||
</%helpers:longhand>
|
</%helpers:longhand>
|
||||||
|
|
||||||
<%helpers:longhand name="contain" animation_type="none" products="none" need_clone="True"
|
// FIXME: `size` and `content` values are not implemented and `strict` is implemented
|
||||||
|
// like `content`(layout style paint) in gecko. We should implement `size` and `content`,
|
||||||
|
// also update the glue once they are implemented in gecko.
|
||||||
|
<%helpers:longhand name="contain" animation_type="none" products="gecko" need_clone="True"
|
||||||
spec="https://drafts.csswg.org/css-contain/#contain-property">
|
spec="https://drafts.csswg.org/css-contain/#contain-property">
|
||||||
use std::fmt;
|
use std::fmt;
|
||||||
use style_traits::ToCss;
|
use style_traits::ToCss;
|
||||||
|
@ -2093,14 +2096,11 @@ ${helpers.single_keyword("transform-style",
|
||||||
bitflags! {
|
bitflags! {
|
||||||
#[cfg_attr(feature = "servo", derive(HeapSizeOf))]
|
#[cfg_attr(feature = "servo", derive(HeapSizeOf))]
|
||||||
pub flags SpecifiedValue: u8 {
|
pub flags SpecifiedValue: u8 {
|
||||||
const SIZE = 0x01,
|
const LAYOUT = 0x01,
|
||||||
const LAYOUT = 0x02,
|
const STYLE = 0x02,
|
||||||
const STYLE = 0x04,
|
const PAINT = 0x04,
|
||||||
const PAINT = 0x08,
|
const STRICT = 0x8,
|
||||||
const STRICT = 0x10,
|
const STRICT_BITS = LAYOUT.bits | STYLE.bits | PAINT.bits,
|
||||||
const STRICT_BITS = SIZE.bits | LAYOUT.bits | STYLE.bits | PAINT.bits,
|
|
||||||
const CONTENT = 0x20,
|
|
||||||
const CONTENT_BITS = LAYOUT.bits | STYLE.bits | PAINT.bits,
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -2112,9 +2112,6 @@ ${helpers.single_keyword("transform-style",
|
||||||
if self.contains(STRICT) {
|
if self.contains(STRICT) {
|
||||||
return dest.write_str("strict")
|
return dest.write_str("strict")
|
||||||
}
|
}
|
||||||
if self.contains(CONTENT) {
|
|
||||||
return dest.write_str("content")
|
|
||||||
}
|
|
||||||
|
|
||||||
let mut has_any = false;
|
let mut has_any = false;
|
||||||
macro_rules! maybe_write_value {
|
macro_rules! maybe_write_value {
|
||||||
|
@ -2128,7 +2125,6 @@ ${helpers.single_keyword("transform-style",
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
maybe_write_value!(SIZE => "size");
|
|
||||||
maybe_write_value!(LAYOUT => "layout");
|
maybe_write_value!(LAYOUT => "layout");
|
||||||
maybe_write_value!(STYLE => "style");
|
maybe_write_value!(STYLE => "style");
|
||||||
maybe_write_value!(PAINT => "paint");
|
maybe_write_value!(PAINT => "paint");
|
||||||
|
@ -2154,14 +2150,9 @@ ${helpers.single_keyword("transform-style",
|
||||||
result.insert(STRICT | STRICT_BITS);
|
result.insert(STRICT | STRICT_BITS);
|
||||||
return Ok(result)
|
return Ok(result)
|
||||||
}
|
}
|
||||||
if input.try(|input| input.expect_ident_matching("content")).is_ok() {
|
|
||||||
result.insert(CONTENT | CONTENT_BITS);
|
|
||||||
return Ok(result)
|
|
||||||
}
|
|
||||||
|
|
||||||
while let Ok(name) = input.try(|input| input.expect_ident()) {
|
while let Ok(name) = input.try(|input| input.expect_ident()) {
|
||||||
let flag = match_ignore_ascii_case! { &name,
|
let flag = match_ignore_ascii_case! { &name,
|
||||||
"size" => SIZE,
|
|
||||||
"layout" => LAYOUT,
|
"layout" => LAYOUT,
|
||||||
"style" => STYLE,
|
"style" => STYLE,
|
||||||
"paint" => PAINT,
|
"paint" => PAINT,
|
||||||
|
|
|
@ -16,16 +16,10 @@ fn contain_longhand_should_parse_correctly() {
|
||||||
let strict = parse_longhand!(contain, "strict");
|
let strict = parse_longhand!(contain, "strict");
|
||||||
assert_eq!(strict, contain::STRICT | contain::STRICT_BITS);
|
assert_eq!(strict, contain::STRICT | contain::STRICT_BITS);
|
||||||
|
|
||||||
let strict = parse_longhand!(contain, "content");
|
|
||||||
assert_eq!(strict, contain::CONTENT | contain::CONTENT_BITS);
|
|
||||||
|
|
||||||
let style_paint = parse_longhand!(contain, "style paint");
|
let style_paint = parse_longhand!(contain, "style paint");
|
||||||
assert_eq!(style_paint, contain::STYLE | contain::PAINT);
|
assert_eq!(style_paint, contain::STYLE | contain::PAINT);
|
||||||
|
|
||||||
assert_roundtrip_with_context!(contain::parse, "strict");
|
assert_roundtrip_with_context!(contain::parse, "strict");
|
||||||
assert_roundtrip_with_context!(contain::parse, "size layout style paint");
|
|
||||||
|
|
||||||
assert_roundtrip_with_context!(contain::parse, "content");
|
|
||||||
assert_roundtrip_with_context!(contain::parse, "layout style paint");
|
assert_roundtrip_with_context!(contain::parse, "layout style paint");
|
||||||
|
|
||||||
// Assert that the `2px` is not consumed, which would trigger parsing failure in real use
|
// Assert that the `2px` is not consumed, which would trigger parsing failure in real use
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue