diff --git a/components/script/dom/bindings/proxyhandler.rs b/components/script/dom/bindings/proxyhandler.rs index ce198da046a..07e215b72c5 100644 --- a/components/script/dom/bindings/proxyhandler.rs +++ b/components/script/dom/bindings/proxyhandler.rs @@ -39,7 +39,6 @@ use js::jsapi::{DOMProxyShadowsResult, JSContext, JSObject, PropertyDescriptor}; use js::jsapi::{GetWellKnownSymbol, SymbolCode}; use js::jsapi::{JSErrNum, SetDOMProxyInformation}; use js::jsid::SymbolId; -use js::jsval::JSVal; use js::jsval::ObjectValue; use js::jsval::UndefinedValue; use js::rust::wrappers::JS_AlreadyHasOwnPropertyById; @@ -194,7 +193,7 @@ pub unsafe fn ensure_expando_object( /// Set the property descriptor's object to `obj` and set it to enumerable, /// and writable if `readonly` is true. pub fn set_property_descriptor( - mut desc: MutableHandle, + desc: MutableHandle, value: HandleValue, attrs: u32, is_none: &mut bool, diff --git a/components/script/window_named_properties.rs b/components/script/window_named_properties.rs index abe42825758..fd579f35d86 100644 --- a/components/script/window_named_properties.rs +++ b/components/script/window_named_properties.rs @@ -11,13 +11,8 @@ use crate::dom::window::Window; use crate::js::conversions::ToJSValConvertible; use crate::script_runtime::JSContext as SafeJSContext; use js::conversions::jsstr_to_string; -use js::glue::{ - AppendToIdVector, CreateProxyHandler, NewProxyObject, ProxyTraps, RUST_SYMBOL_TO_JSID, -}; -use js::jsapi::{ - jsid, GetPropertyKeys, GetWellKnownSymbol, JS_SetImmutablePrototype, SymbolCode, JSITER_HIDDEN, - JSITER_OWNONLY, JSITER_SYMBOLS, -}; +use js::glue::{AppendToIdVector, CreateProxyHandler, NewProxyObject, ProxyTraps}; +use js::jsapi::{GetWellKnownSymbol, JS_SetImmutablePrototype, SymbolCode}; use js::jsapi::{ Handle, HandleObject, JSClass, JSContext, JSErrNum, MutableHandleObject, UndefinedHandleValue, }; @@ -124,7 +119,7 @@ unsafe extern "C" fn get_own_property_descriptor( // If the property key is an integer index, convert it to a String too. // TODO(delan) will this interfere with indexed access on the Window object // (window[index]), which should only return document-tree child navigables? - // https://html.spec.whatwg.org/#accessing-other-browsing-contexts + // https://html.spec.whatwg.org/multipage/#accessing-other-browsing-contexts id.to_int().to_string() } else if id.is_symbol() { unreachable!()