Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 13:40:08 +01:00
Code Issues Projects Releases Packages Wiki Activity

Implement the unitless length quirk for physical size properties

Browse source
This commit is contained in:
Anthony Ramine 2017-04-24 17:31:03 +02:00
parent 0e7308e6dc
commit 65f74ea934
3 changed files with 11 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

1
components/style/properties/longhand/position.mako.rs
View file

@ -158,6 +158,7 @@ ${helpers.predefined_type("flex-basis",
"computed::LengthOrPercentageOrAuto::Auto", "computed::LengthOrPercentageOrAuto::Auto",
"parse_non_negative", "parse_non_negative",
spec=spec % size, spec=spec % size,
allow_quirks=not logical,
animation_value_type="ComputedValue", logical = logical)} animation_value_type="ComputedValue", logical = logical)}
% if product == "gecko": % if product == "gecko":
% for min_max in ["min", "max"]: % for min_max in ["min", "max"]:

11
components/style/values/specified/length.rs
View file

@ -1360,7 +1360,16 @@ impl LengthOrPercentageOrAuto {
/// Parse a non-negative length, percentage, or auto. /// Parse a non-negative length, percentage, or auto.
#[inline] #[inline]
pub fn parse_non_negative(context: &ParserContext, input: &mut Parser) -> Result<LengthOrPercentageOrAuto, ()> { pub fn parse_non_negative(context: &ParserContext, input: &mut Parser) -> Result<LengthOrPercentageOrAuto, ()> {
Self::parse_internal(context, input, AllowedLengthType::NonNegative, AllowQuirks::No) Self::parse_non_negative_quirky(context, input, AllowQuirks::No)
}
/// Parse a non-negative length, percentage, or auto.
#[inline]
pub fn parse_non_negative_quirky(context: &ParserContext,
input: &mut Parser,
allow_quirks: AllowQuirks)
-> Result<Self, ()> {
Self::parse_internal(context, input, AllowedLengthType::NonNegative, allow_quirks)
} }
/// Returns the `auto` value. /// Returns the `auto` value.

24
tests/wpt/metadata/quirks-mode/unitless-length.html.ini
View file

@ -12,9 +12,6 @@
expected: expected:
if os == "mac": FAIL if os == "mac": FAIL
[height: 1 (quirks)]
expected: FAIL
[letter-spacing: 1 (quirks)] [letter-spacing: 1 (quirks)]
expected: FAIL expected: FAIL
@ -75,9 +72,6 @@
[vertical-align: 1 (quirks)] [vertical-align: 1 (quirks)]
expected: FAIL expected: FAIL
[width: 1 (quirks)]
expected: FAIL
[word-spacing: 1 (quirks)] [word-spacing: 1 (quirks)]
expected: FAIL expected: FAIL
@ -93,9 +87,6 @@
expected: expected:
if os == "mac": FAIL if os == "mac": FAIL
[height: +1 (quirks)]
expected: FAIL
[letter-spacing: +1 (quirks)] [letter-spacing: +1 (quirks)]
expected: FAIL expected: FAIL
@ -156,9 +147,6 @@
[vertical-align: +1 (quirks)] [vertical-align: +1 (quirks)]
expected: FAIL expected: FAIL
[width: +1 (quirks)]
expected: FAIL
[word-spacing: +1 (quirks)] [word-spacing: +1 (quirks)]
expected: FAIL expected: FAIL
@ -225,9 +213,6 @@
expected: expected:
if os == "mac": FAIL if os == "mac": FAIL
[height: 1.5 (quirks)]
expected: FAIL
[letter-spacing: 1.5 (quirks)] [letter-spacing: 1.5 (quirks)]
expected: FAIL expected: FAIL
@ -288,9 +273,6 @@
[vertical-align: 1.5 (quirks)] [vertical-align: 1.5 (quirks)]
expected: FAIL expected: FAIL
[width: 1.5 (quirks)]
expected: FAIL
[word-spacing: 1.5 (quirks)] [word-spacing: 1.5 (quirks)]
expected: FAIL expected: FAIL
@ -306,9 +288,6 @@
expected: expected:
if os == "mac": FAIL if os == "mac": FAIL
[height: +1.5 (quirks)]
expected: FAIL
[letter-spacing: +1.5 (quirks)] [letter-spacing: +1.5 (quirks)]
expected: FAIL expected: FAIL
@ -369,9 +348,6 @@
[vertical-align: +1.5 (quirks)] [vertical-align: +1.5 (quirks)]
expected: FAIL expected: FAIL
[width: +1.5 (quirks)]
expected: FAIL
[word-spacing: +1.5 (quirks)] [word-spacing: +1.5 (quirks)]
expected: FAIL expected: FAIL