Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-07 14:35:33 +01:00
Code Issues Projects Releases Packages Wiki Activity

Temporarily convert existing cfg(debug_assertions) crashes to warnings (#30578)

Browse source
This commit is contained in:
Delan Azabani 2023-10-18 21:16:11 +08:00 • committed by GitHub
parent 351b5036bf
commit 66258bfbbd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
9 changed files with 53 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

16
components/style/logical_geometry.rs
View file

@ -570,6 +570,22 @@ impl<T: Add<T, Output = T>> Add for LogicalSize<T> {
}
}
// TODO(servo#30577) remove this once underlying bugs are fixed
impl<T: Add<T, Output = T>> LogicalSize<T> {
#[inline]
pub fn add_or_warn(self, other: LogicalSize<T>) -> LogicalSize<T> {
#[cfg(debug_assertions)]
if !(self.debug_writing_mode.mode == other.debug_writing_mode.mode) {
log::warn!("debug assertion failed! self.debug_writing_mode.mode == other.debug_writing_mode.mode");
}
LogicalSize {
debug_writing_mode: self.debug_writing_mode,
inline: self.inline + other.inline,
block: self.block + other.block,
}
}
}
impl<T: Sub<T, Output = T>> Sub for LogicalSize<T> {
type Output = LogicalSize<T>;