Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-02 12:10:29 +01:00
Code Issues Projects Releases Packages Wiki Activity

Make tidy search for files recursively again

Browse source 
In #7348 `os.walk` was replaced with `os.listdir`. The latter is not
recursive, which results in only the root directory files getting linted

The changes to `ignored_files` are needed because calling `os.walk(".")`
results in `./` getting prefixed before each path
This commit is contained in:
Corey Farwell 2015-08-24 20:28:47 -04:00
parent c790c4d4cd
commit 662b64ffe4
1 changed files with 16 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

32
python/tidy.py
View file

@ -27,26 +27,26 @@ python_dependencies = [
ignored_files = [ ignored_files = [
# Upstream # Upstream
"support/*", "./support/*",
"tests/wpt/*", "./tests/wpt/*",
"python/mach/*", "./python/mach/*",
"python/mozdebug/*", "./python/mozdebug/*",
"python/mozinfo/*", "./python/mozinfo/*",
"python/mozlog/*", "./python/mozlog/*",
"python/toml/*", "./python/toml/*",
"components/script/dom/bindings/codegen/parser/*", "./components/script/dom/bindings/codegen/parser/*",
"components/script/dom/bindings/codegen/ply/*", "./components/script/dom/bindings/codegen/ply/*",
# Generated and upstream code combined with our own. Could use cleanup # Generated and upstream code combined with our own. Could use cleanup
"target/*", "./target/*",
"ports/gonk/src/native_window_glue.cpp", "./ports/gonk/src/native_window_glue.cpp",
"ports/cef/*", "./ports/cef/*",
# MIT license # MIT license
"components/util/deque/mod.rs", "./components/util/deque/mod.rs",
# Hidden files/directories # Hidden files/directories
".*", "./.*",
] ]
@ -384,14 +384,14 @@ def check_reftest_html_files_in_basic_list(reftest_dir):
def scan(): def scan():
sys.path += python_dependencies sys.path += python_dependencies
all_files = os.listdir(".") all_files = (os.path.join(r, f) for r, _, files in os.walk(".") for f in files)
files_to_check = filter(should_check, all_files) files_to_check = filter(should_check, all_files)
checking_functions = [check_license, check_by_line, check_flake8, check_toml, checking_functions = [check_license, check_by_line, check_flake8, check_toml,
check_rust, check_webidl_spec, check_spec] check_rust, check_webidl_spec, check_spec]
errors = collect_errors_for_files(files_to_check, checking_functions) errors = collect_errors_for_files(files_to_check, checking_functions)
reftest_files = [os.path.join(reftest_dir, file) for file in os.listdir(reftest_dir)] reftest_files = (os.path.join(r, f) for r, _, files in os.walk(reftest_dir) for f in files)
reftest_to_check = filter(should_check_reftest, reftest_files) reftest_to_check = filter(should_check_reftest, reftest_files)
r_errors = check_reftest_order(reftest_to_check) r_errors = check_reftest_order(reftest_to_check)
not_found_in_basic_list_errors = check_reftest_html_files_in_basic_list(reftest_dir) not_found_in_basic_list_errors = check_reftest_html_files_in_basic_list(reftest_dir)