Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-05 12:38:21 +01:00
Code Issues Projects Releases Packages Wiki Activity

indexeddb: Return error instead of panicking on structured clone failure (#39078)

Browse source 
Related to failures in #38847

Testing: WPT

---------

Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
This commit is contained in:
Ashwin Naren 2025-09-01 18:22:19 -07:00 • committed by GitHub
parent ce8b05738c
commit 665ee150a6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 5 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
components/script/indexed_db.rs
View file

@ -145,7 +145,7 @@ pub fn convert_value_to_key(
if IsArrayBufferObject(*object) || JS_IsArrayBufferViewObject(*object) { if IsArrayBufferObject(*object) || JS_IsArrayBufferViewObject(*object) {
// FIXME:(arihant2math) implement it the correct way (is this correct?) // FIXME:(arihant2math) implement it the correct way (is this correct?)
let key = structuredclone::write(cx, input, None).expect("Could not serialize key"); let key = structuredclone::write(cx, input, None)?;
return Ok(IndexedDBKeyType::Binary(key.serialized.clone())); return Ok(IndexedDBKeyType::Binary(key.serialized.clone()));
} }

2
tests/wpt/meta/IndexedDB/crashtests/create-index.any.js.ini vendored
View file

@ -5,7 +5,7 @@
[create-index.any.worker.html] [create-index.any.worker.html]
expected: TIMEOUT expected: CRASH
[Assure no crash when populating index] [Assure no crash when populating index]
expected: TIMEOUT expected: TIMEOUT

2
tests/wpt/meta/IndexedDB/idb-binary-key-detached.any.js.ini vendored
View file

@ -1,5 +1,4 @@
[idb-binary-key-detached.any.html] [idb-binary-key-detached.any.html]
expected: CRASH
[Detached ArrayBuffers must throw DataError when used as a key] [Detached ArrayBuffers must throw DataError when used as a key]
expected: FAIL expected: FAIL
@ -8,7 +7,6 @@
[idb-binary-key-detached.any.worker.html] [idb-binary-key-detached.any.worker.html]
expected: CRASH
[Detached ArrayBuffers must throw DataError when used as a key] [Detached ArrayBuffers must throw DataError when used as a key]
expected: FAIL expected: FAIL

6
tests/wpt/meta/IndexedDB/idbfactory_open.any.js.ini vendored
View file

@ -2,9 +2,6 @@
[IDBFactory.open() - error in version change transaction aborts open] [IDBFactory.open() - error in version change transaction aborts open]
expected: FAIL expected: FAIL
[Calling open() with version argument 1.5 should not throw.]
expected: FAIL
[Calling open() with version argument undefined should not throw.] [Calling open() with version argument undefined should not throw.]
expected: FAIL expected: FAIL
@ -39,3 +36,6 @@
[Calling open() with version argument 9007199254740991 should not throw.] [Calling open() with version argument 9007199254740991 should not throw.]
expected: FAIL expected: FAIL
[Calling open() with version argument 1.5 should not throw.]
expected: FAIL