Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-04 13:10:20 +01:00
Code Issues Projects Releases Packages Wiki Activity

script: fix querySelector returning the root (#33174)

Browse source 
Signed-off-by: Nolan Lawson <nolan@nolanlawson.com>
This commit is contained in:
Nolan Lawson 2024-08-25 02:16:26 -07:00 • committed by GitHub
parent c79d9e68a3
commit 67e2bb0ee6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 4 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

6
components/script/dom/node.rs
View file

@ -982,8 +982,10 @@ impl Node {
NeedsSelectorFlags::No, NeedsSelectorFlags::No,
MatchingForInvalidation::No, MatchingForInvalidation::No,
); );
Ok(self let mut descendants = self.traverse_preorder(ShadowIncluding::No);
.traverse_preorder(ShadowIncluding::No) // Skip the root of the tree.
assert!(&*descendants.next().unwrap() == self);
Ok(descendants
.filter_map(DomRoot::downcast) .filter_map(DomRoot::downcast)
.find(|element| matches_selector_list(&selectors, element, &mut ctx))) .find(|element| matches_selector_list(&selectors, element, &mut ctx)))
}, },

3
tests/wpt/meta/dom/nodes/ParentNode-querySelector-scope.html.ini vendored
View file

@ -8,8 +8,5 @@
[querySelector with :scope] [querySelector with :scope]
expected: FAIL expected: FAIL
[querySelector with id and sibling]
expected: FAIL
[querySelectorAll with :scope] [querySelectorAll with :scope]
expected: FAIL expected: FAIL

4
tests/wpt/meta/dom/nodes/ParentNode-querySelectors-exclusive.html.ini vendored
View file

@ -1,4 +0,0 @@
[ParentNode-querySelectors-exclusive.html]
[querySelector/querySelectorAll should not include their thisArg]
expected: FAIL