Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-23 07:13:52 +01:00
Code Issues Projects Releases Packages Wiki Activity

Add CanGc as arguments in methods in Attr and Node (#36371)

Browse source 
Add CanGc as argument to methods in `Attr` and `Node`.

Addressed part of https://github.com/servo/servo/issues/34573.

---

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because they are a refactor.

Signed-off-by: Yerkebulan Tulibergenov <yerkebulan@gmail.com>
This commit is contained in:
Yerkebulan Tulibergenov 2025-04-05 23:27:59 -07:00 • committed by GitHub
parent bd43b78735
commit 6898eae61e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
20 changed files with 137 additions and 111 deletions
Download patch file Download diff file Expand all files Collapse all files

8
components/script/devtools.rs
View file

@ -105,7 +105,7 @@ pub(crate) fn handle_get_root_node(
) {
let info = documents
.find_document(pipeline)
.map(|document| document.upcast::<Node>().summarize());
.map(|document| document.upcast::<Node>().summarize(CanGc::note()));
reply.send(info).unwrap();
}
@ -117,7 +117,7 @@ pub(crate) fn handle_get_document_element(
let info = documents
.find_document(pipeline)
.and_then(|document| document.GetDocumentElement())
.map(|element| element.upcast::<Node>().summarize());
.map(|element| element.upcast::<Node>().summarize(CanGc::note()));
reply.send(info).unwrap();
}
@ -166,7 +166,7 @@ pub(crate) fn handle_get_children(
if !shadow_root.is_user_agent_widget() ||
pref!(inspector_show_servo_internal_shadow_roots)
{
children.push(shadow_root.upcast::<Node>().summarize());
children.push(shadow_root.upcast::<Node>().summarize(CanGc::note()));
}
}
let children_iter = parent.children().enumerate().filter_map(|(i, child)| {
@ -175,7 +175,7 @@ pub(crate) fn handle_get_children(
let prev_inline = i > 0 && inline[i - 1];
let next_inline = i < inline.len() - 1 && inline[i + 1];
let info = child.summarize();
let info = child.summarize(CanGc::note());
if !is_whitespace(&info) {
return Some(info);
}