mirror of
https://github.com/servo/servo.git
synced 2025-08-06 06:00:15 +01:00
Add CanGc as arguments in methods in Attr and Node (#36371)
Add CanGc as argument to methods in `Attr` and `Node`. Addressed part of https://github.com/servo/servo/issues/34573. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because they are a refactor. Signed-off-by: Yerkebulan Tulibergenov <yerkebulan@gmail.com>
This commit is contained in:
parent
bd43b78735
commit
6898eae61e
20 changed files with 137 additions and 111 deletions
|
@ -286,7 +286,7 @@ impl HTMLSelectElement {
|
|||
);
|
||||
select_box
|
||||
.upcast::<Node>()
|
||||
.AppendChild(text_container.upcast::<Node>())
|
||||
.AppendChild(text_container.upcast::<Node>(), can_gc)
|
||||
.unwrap();
|
||||
|
||||
let text = Text::new(DOMString::new(), &document, can_gc);
|
||||
|
@ -295,7 +295,7 @@ impl HTMLSelectElement {
|
|||
});
|
||||
text_container
|
||||
.upcast::<Node>()
|
||||
.AppendChild(text.upcast::<Node>())
|
||||
.AppendChild(text.upcast::<Node>(), can_gc)
|
||||
.unwrap();
|
||||
|
||||
let chevron_container =
|
||||
|
@ -310,11 +310,11 @@ impl HTMLSelectElement {
|
|||
.SetTextContent(Some("▾".into()), can_gc);
|
||||
select_box
|
||||
.upcast::<Node>()
|
||||
.AppendChild(chevron_container.upcast::<Node>())
|
||||
.AppendChild(chevron_container.upcast::<Node>(), can_gc)
|
||||
.unwrap();
|
||||
|
||||
root.upcast::<Node>()
|
||||
.AppendChild(select_box.upcast::<Node>())
|
||||
.AppendChild(select_box.upcast::<Node>(), can_gc)
|
||||
.unwrap();
|
||||
}
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue