Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-04 13:10:20 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fix private browsing mode preservation when loading URL

Browse source
This commit is contained in:
mandreyel 2018-09-14 11:29:00 +02:00
parent 170e232606
commit 68b6bbd35f
1 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
components/constellation/constellation.rs
View file

@ -2064,12 +2064,13 @@ where
return None; return None;
}, },
}; };
let (window_size, pipeline_id, parent_pipeline_id, is_visible) = let (window_size, pipeline_id, parent_pipeline_id, is_private, is_visible) =
match self.browsing_contexts.get(&browsing_context_id) { match self.browsing_contexts.get(&browsing_context_id) {
Some(ctx) => ( Some(ctx) => (
ctx.size, ctx.size,
ctx.pipeline_id, ctx.pipeline_id,
ctx.parent_pipeline_id, ctx.parent_pipeline_id,
ctx.is_private,
ctx.is_visible, ctx.is_visible,
), ),
None => { None => {
@ -2141,9 +2142,6 @@ where
let new_pipeline_id = PipelineId::new(); let new_pipeline_id = PipelineId::new();
let sandbox = IFrameSandboxState::IFrameUnsandboxed; let sandbox = IFrameSandboxState::IFrameUnsandboxed;
// TODO(mandreyel): why is this false? Should we not inherit the
// privacy of the (existing) browsing context?
let is_private = false;
self.new_pipeline( self.new_pipeline(
new_pipeline_id, new_pipeline_id,
browsing_context_id, browsing_context_id,