From 68f3daa7ef9936ee57e12cf48c2dedf051fd3791 Mon Sep 17 00:00:00 2001 From: Ms2ger Date: Sun, 2 Nov 2014 18:04:03 +0100 Subject: [PATCH] Simplify the implementation of NodeIterator::next_child. --- components/script/dom/node.rs | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/components/script/dom/node.rs b/components/script/dom/node.rs index 28899bbd404..af1afccc3b1 100644 --- a/components/script/dom/node.rs +++ b/components/script/dom/node.rs @@ -1050,15 +1050,13 @@ impl NodeIterator { } fn next_child<'b>(&self, node: JSRef<'b, Node>) -> Option> { - if !self.include_descendants_of_void && node.is_element() { - let elem: JSRef = ElementCast::to_ref(node).unwrap(); - if elem.is_void() { - None - } else { - node.first_child().map(|child| (*child.root()).clone()) - } - } else { - node.first_child().map(|child| (*child.root()).clone()) + let skip = |element: JSRef| { + !self.include_descendants_of_void && element.is_void() + }; + + match ElementCast::to_ref(node) { + Some(element) if skip(element) => None, + _ => node.first_child().map(|child| (*child.root()).clone()), } } }