Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-23 15:23:42 +01:00
Code Issues Projects Releases Packages Wiki Activity

webgl: return missing attachment status from framebuffers with no attachments.

Browse source
This commit is contained in:
Josh Matthews 2018-08-22 15:09:05 -04:00
parent da3b0ef88f
commit 690c98dda7
2 changed files with 2 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

4
components/script/dom/webglframebuffer.rs
View file

@ -66,7 +66,7 @@ impl WebGLFramebuffer {
target: Cell::new(None), target: Cell::new(None),
is_deleted: Cell::new(false), is_deleted: Cell::new(false),
size: Cell::new(None), size: Cell::new(None),
status: Cell::new(constants::FRAMEBUFFER_UNSUPPORTED), status: Cell::new(constants::FRAMEBUFFER_INCOMPLETE_MISSING_ATTACHMENT),
color: DomRefCell::new(None), color: DomRefCell::new(None),
depth: DomRefCell::new(None), depth: DomRefCell::new(None),
stencil: DomRefCell::new(None), stencil: DomRefCell::new(None),
@ -206,7 +206,7 @@ impl WebGLFramebuffer {
self.status.set(constants::FRAMEBUFFER_INCOMPLETE_ATTACHMENT); self.status.set(constants::FRAMEBUFFER_INCOMPLETE_ATTACHMENT);
} }
} else { } else {
self.status.set(constants::FRAMEBUFFER_UNSUPPORTED); self.status.set(constants::FRAMEBUFFER_INCOMPLETE_MISSING_ATTACHMENT);
} }
} }

9
tests/wpt/webgl/meta/conformance/renderbuffers/framebuffer-object-attachment.html.ini
View file

@ -2,20 +2,11 @@
[WebGL test #139: at (0, 0) expected: 0,255,0,255 was 255,0,0,255] [WebGL test #139: at (0, 0) expected: 0,255,0,255 was 255,0,0,255]
expected: fail expected: fail
[WebGL test #522: gl.checkFramebufferStatus(gl.FRAMEBUFFER) should be FRAMEBUFFER_INCOMPLETE_MISSING_ATTACHMENT was FRAMEBUFFER_UNSUPPORTED or FRAMEBUFFER_UNSUPPORTED]
expected: FAIL
[WebGL test #537: gl.checkFramebufferStatus(gl.FRAMEBUFFER) should be FRAMEBUFFER_INCOMPLETE_MISSING_ATTACHMENT was FRAMEBUFFER_UNSUPPORTED or FRAMEBUFFER_UNSUPPORTED]
expected: FAIL
[WebGL test #559: getError expected: INVALID_OPERATION. Was INVALID_FRAMEBUFFER_OPERATION : After CopyTexSubImage2D from missing attachment] [WebGL test #559: getError expected: INVALID_OPERATION. Was INVALID_FRAMEBUFFER_OPERATION : After CopyTexSubImage2D from missing attachment]
expected: FAIL expected: FAIL
[WebGL test #555: getError expected: INVALID_OPERATION. Was INVALID_FRAMEBUFFER_OPERATION : After ReadPixels from missing attachment] [WebGL test #555: getError expected: INVALID_OPERATION. Was INVALID_FRAMEBUFFER_OPERATION : After ReadPixels from missing attachment]
expected: FAIL expected: FAIL
[WebGL test #519: gl.checkFramebufferStatus(gl.FRAMEBUFFER) should be FRAMEBUFFER_INCOMPLETE_MISSING_ATTACHMENT was FRAMEBUFFER_UNSUPPORTED or FRAMEBUFFER_UNSUPPORTED]
expected: FAIL
[WebGL test #557: getError expected: INVALID_OPERATION. Was INVALID_FRAMEBUFFER_OPERATION : After CopyTexImage2D from missing attachment] [WebGL test #557: getError expected: INVALID_OPERATION. Was INVALID_FRAMEBUFFER_OPERATION : After CopyTexImage2D from missing attachment]
expected: FAIL expected: FAIL