mirror of
https://github.com/servo/servo.git
synced 2025-08-06 22:15:33 +01:00
Auto merge of #19651 - pyfisch:background-placement, r=emilio
Unify background placement code Merges the implementations for background-image placement from gradients and images. Add missing parts and fix bugs. Now supported are the CSS properties: * background-attachment (except for local value, see #19650) * background-clip * background-origin * background-position-x/y * background-repeat * background-size It should be noted that backgrounds are not clipped to rounded border corners. (This was done before but worked only in simple cases) See: #19649 This solves the following issues: closes #19626 closes #16657 closes #19482 (examples from http://lea.verou.me/css3patterns/ are rendered perfectly but the round border is completely ignored now) closes #19577 - `./mach build -d` does not report any errors - `./mach test-tidy` does not report any errors I enabled a few tests with the first commit but I have written about a dozen manual tests I will try to turn into ref tests either before or after this patch lands. @bors-servo try The relationship between the different inputs is visualized in this flowchart:  <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19651) <!-- Reviewable:end -->
This commit is contained in:
commit
691bff86b6
24 changed files with 396 additions and 380 deletions
|
@ -729,6 +729,7 @@ pub struct GradientDisplayItem {
|
|||
///
|
||||
/// Without tiles, the tile will be the same size as the background.
|
||||
pub tile: Size2D<Au>,
|
||||
pub tile_spacing: Size2D<Au>,
|
||||
}
|
||||
|
||||
/// Paints a radial gradient.
|
||||
|
@ -763,6 +764,7 @@ pub struct RadialGradientDisplayItem {
|
|||
///
|
||||
/// Without tiles, the tile will be the same size as the background.
|
||||
pub tile: Size2D<Au>,
|
||||
pub tile_spacing: Size2D<Au>,
|
||||
}
|
||||
|
||||
/// A normal border, supporting CSS border styles.
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue