Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-10-01 17:19:16 +01:00
Code Issues Projects Releases Packages Wiki Activity

compositor: Add Paint Metric events to Perfetto Traces (#39502)

Browse source 
> Some metrics like TimeToFirstPaint and TimeToFirstContentfulPaint are
only in the HTML traces. [See
this](https://github.com/servo/perf-analysis-tools?tab=readme-ov-file#how-to-analyse-a-single-servo-sample)

In order to analyse the performance and refine
[perf-analysis-tools](https://github.com/servo/perf-analysis-tools) we
need these metrics to be added to Perfetto also.

<img width="993" height="359" alt="Screenshot from 2025-09-26 15-00-00"
src="https://github.com/user-attachments/assets/9755f344-a98e-4671-b347-d76cd6311afe"
/>

<img width="1186" height="359" alt="Screenshot from 2025-09-26 15-00-42"
src="https://github.com/user-attachments/assets/a25e3a5f-eef0-45b7-be69-5de919bfb663"
/>

Testing: Verified by using Perfetto traces

Signed-off-by: Shubham Gupta <shubham.gupta@chromium.org>
This commit is contained in:
Shubham Gupta 2025-09-30 19:07:35 +08:00 • committed by GitHub
parent 0c22f784bb
commit 6995e60ee1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 16 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

16
components/compositing/compositor.rs
View file

@ -1383,6 +1383,14 @@ impl IOCompositor {
// the first "real" display list. // the first "real" display list.
PaintMetricState::Seen(epoch, first_reflow) if epoch <= current_epoch => { PaintMetricState::Seen(epoch, first_reflow) if epoch <= current_epoch => {
assert!(epoch <= current_epoch); assert!(epoch <= current_epoch);
#[cfg(feature = "tracing")]
tracing::info!(
name: "FirstPaint",
servo_profiling = true,
epoch = ?epoch,
paint_time = ?paint_time,
pipeline_id = ?pipeline_id,
);
if let Err(error) = self.global.borrow().constellation_sender.send( if let Err(error) = self.global.borrow().constellation_sender.send(
EmbedderToConstellationMessage::PaintMetric( EmbedderToConstellationMessage::PaintMetric(
*pipeline_id, *pipeline_id,
@ -1400,6 +1408,14 @@ impl IOCompositor {
match pipeline.first_contentful_paint_metric { match pipeline.first_contentful_paint_metric {
PaintMetricState::Seen(epoch, first_reflow) if epoch <= current_epoch => { PaintMetricState::Seen(epoch, first_reflow) if epoch <= current_epoch => {
#[cfg(feature = "tracing")]
tracing::info!(
name: "FirstContentfulPaint",
servo_profiling = true,
epoch = ?epoch,
paint_time = ?paint_time,
pipeline_id = ?pipeline_id,
);
if let Err(error) = self.global.borrow().constellation_sender.send( if let Err(error) = self.global.borrow().constellation_sender.send(
EmbedderToConstellationMessage::PaintMetric( EmbedderToConstellationMessage::PaintMetric(
*pipeline_id, *pipeline_id,