Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 12:40:06 +01:00
Code Issues Projects Releases Packages Wiki Activity

Refactor .sort_by() calls to use .partial_cmp()

Browse source
This commit is contained in:
Mateusz Naściszewski 2017-09-01 22:34:46 +02:00
parent fd833d9f18
commit 699681d800
No known key found for this signature in database
GPG key ID: 6A6067123E4CAF6E
1 changed files with 3 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

24
components/profile/time.rs
View file

@ -355,13 +355,7 @@ impl Profiler {
write!(file, "_category_\t_incremental?_\t_iframe?_\t_url_\t_mean (ms)_\t\ write!(file, "_category_\t_incremental?_\t_iframe?_\t_url_\t_mean (ms)_\t\
_median (ms)_\t_min (ms)_\t_max (ms)_\t_events_\n").unwrap(); _median (ms)_\t_min (ms)_\t_max (ms)_\t_events_\n").unwrap();
for (&(ref category, ref meta), ref mut data) in &mut self.buckets { for (&(ref category, ref meta), ref mut data) in &mut self.buckets {
data.sort_by(|a, b| { data.sort_by(|a, b| a.partial_cmp(b).expect("No NaN values in profiles"));
if a < b {
Ordering::Less
} else {
Ordering::Greater
}
});
let data_len = data.len(); let data_len = data.len();
if data_len > 0 { if data_len > 0 {
let (mean, median, min, max) = Self::get_statistics(data); let (mean, median, min, max) = Self::get_statistics(data);
@ -380,13 +374,7 @@ impl Profiler {
" _url_", " _mean (ms)_", " _median (ms)_", " _url_", " _mean (ms)_", " _median (ms)_",
" _min (ms)_", " _max (ms)_", " _events_").unwrap(); " _min (ms)_", " _max (ms)_", " _events_").unwrap();
for (&(ref category, ref meta), ref mut data) in &mut self.buckets { for (&(ref category, ref meta), ref mut data) in &mut self.buckets {
data.sort_by(|a, b| { data.sort_by(|a, b| a.partial_cmp(b).expect("No NaN values in profiles"));
if a < b {
Ordering::Less
} else {
Ordering::Greater
}
});
let data_len = data.len(); let data_len = data.len();
if data_len > 0 { if data_len > 0 {
let (mean, median, min, max) = Self::get_statistics(data); let (mean, median, min, max) = Self::get_statistics(data);
@ -418,13 +406,7 @@ impl Profiler {
let client = create_client(credentials, hosts); let client = create_client(credentials, hosts);
for (&(ref category, ref meta), ref mut data) in &mut self.buckets { for (&(ref category, ref meta), ref mut data) in &mut self.buckets {
data.sort_by(|a, b| { data.sort_by(|a, b| a.partial_cmp(b).expect("No NaN values in profiles"));
if a < b {
Ordering::Less
} else {
Ordering::Greater
}
});
let data_len = data.len(); let data_len = data.len();
if data_len > 0 { if data_len > 0 {
let (mean, median, min, max) = Self::get_statistics(data); let (mean, median, min, max) = Self::get_statistics(data);