Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 21:50:18 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fix gl.getShaderSource and gl.getShaderInfoLog

Browse source 
It only returns null if there was an error, and the only error isn't
implemented yet.
This commit is contained in:
Anthony Ramine 2018-07-07 21:52:10 +02:00
parent 0e93f06d8d
commit 6996d1ce36
3 changed files with 13 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

6
components/script/dom/webglrenderingcontext.rs
View file

@ -2527,7 +2527,8 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext {
// https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14.9
fn GetShaderInfoLog(&self, shader: &WebGLShader) -> Option<DOMString> {
shader.info_log().map(DOMString::from)
// TODO(nox): https://github.com/servo/servo/issues/21133
Some(shader.info_log())
}
#[allow(unsafe_code)]
@ -2973,7 +2974,8 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext {
// https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14.9
fn GetShaderSource(&self, shader: &WebGLShader) -> Option<DOMString> {
shader.source()
// TODO(nox): https://github.com/servo/servo/issues/21133
Some(shader.source())
}
// https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14.10