Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-22 23:03:42 +01:00
Code Issues Projects Releases Packages Wiki Activity

Expose TextTrack.activeCues

Browse source
This commit is contained in:
Fernando Jiménez Moreno 2019-01-11 16:50:49 +01:00
parent 2a7862540c
commit 69a79c7d75
3 changed files with 8 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

7
components/script/dom/texttrack.rs
View file

@ -110,6 +110,13 @@ impl TextTrackMethods for TextTrack {
} }
} }
// https://html.spec.whatwg.org/multipage/#dom-texttrack-activecues
fn GetActiveCues(&self) -> Option<DomRoot<TextTrackCueList>> {
// XXX implement active cues logic
// https://github.com/servo/servo/issues/22314
None
}
// https://html.spec.whatwg.org/multipage/#dom-texttrack-addcue // https://html.spec.whatwg.org/multipage/#dom-texttrack-addcue
fn AddCue(&self, cue: &TextTrackCue) -> ErrorResult { fn AddCue(&self, cue: &TextTrackCue) -> ErrorResult {
// FIXME(#22314, dlrobertson) add Step 1 & 2 // FIXME(#22314, dlrobertson) add Step 1 & 2

2
components/script/dom/webidls/TextTrack.webidl
View file

@ -19,7 +19,7 @@ interface TextTrack : EventTarget {
attribute TextTrackMode mode; attribute TextTrackMode mode;
readonly attribute TextTrackCueList? cues; readonly attribute TextTrackCueList? cues;
// readonly attribute TextTrackCueList? activeCues; readonly attribute TextTrackCueList? activeCues;
[Throws] [Throws]
void addCue(TextTrackCue cue); void addCue(TextTrackCue cue);

6
tests/wpt/metadata/html/dom/interfaces.https.html.ini
View file

@ -9563,15 +9563,9 @@
[TextTrack interface: attribute inBandMetadataTrackDispatchType] [TextTrack interface: attribute inBandMetadataTrackDispatchType]
expected: FAIL expected: FAIL
[TextTrack interface: attribute activeCues]
expected: FAIL
[TextTrack interface: document.createElement("track").track must inherit property "inBandMetadataTrackDispatchType" with the proper type] [TextTrack interface: document.createElement("track").track must inherit property "inBandMetadataTrackDispatchType" with the proper type]
expected: FAIL expected: FAIL
[TextTrack interface: document.createElement("track").track must inherit property "activeCues" with the proper type]
expected: FAIL
[TimeRanges must be primary interface of document.createElement("video").buffered] [TimeRanges must be primary interface of document.createElement("video").buffered]
expected: FAIL expected: FAIL