Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 22:15:33 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #21856 - zcorpan:zcorpan/remove-td-th-interfaces, r=jdm

Browse source 
Remove the HTMLTable{Header,Data}CellElement interfaces

Fixes #17222.

<!-- Please describe your changes on the following line: -->
This removes the `HTMLTableHeaderCellElement` and `HTMLTableDataCellElement` interfaces and uses the `HTMLTableCellElement` interface for both `th` and `td` elements, as per the spec.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #17222.

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21856)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2018-10-12 09:30:41 -04:00 • committed by GitHub
commit 69e5243810
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
19 changed files with 42 additions and 191 deletions
Download patch file Download diff file Expand all files Collapse all files

5
tests/wpt/metadata/custom-elements/builtin-coverage.html.ini
View file

@ -1,5 +1,4 @@
[builtin-coverage.html]
expected: ERROR
[Untitled]
expected: FAIL
@ -385,8 +384,6 @@
expected: FAIL
[td: Operator 'new' should instantiate a customized built-in element]
expected: FAIL
[td: document.createElement() should instantiate a customized built-in element]
expected: FAIL
[td: innerHTML should instantiate a customized built-in element]
expected: FAIL
[template: Operator 'new' should instantiate a customized built-in element]
@ -403,8 +400,6 @@
expected: FAIL
[th: Operator 'new' should instantiate a customized built-in element]
expected: FAIL
[th: document.createElement() should instantiate a customized built-in element]
expected: FAIL
[th: innerHTML should instantiate a customized built-in element]
expected: FAIL
[thead: Operator 'new' should instantiate a customized built-in element]

6
tests/wpt/metadata/html/dom/historical.html.ini
View file

@ -3,9 +3,3 @@
[document.all cannot find applet]
expected: FAIL
[HTMLTableHeaderCellElement interface is removed]
expected: FAIL
[HTMLTableDataCellElement interface is removed]
expected: FAIL

24
tests/wpt/metadata/html/dom/interfaces.https.html.ini
View file

@ -2231,12 +2231,6 @@
[HTMLTableCellElement interface: attribute vAlign]
expected: FAIL
[HTMLTableCellElement must be primary interface of document.createElement("td")]
expected: FAIL
[Stringification of document.createElement("td")]
expected: FAIL
[HTMLTableCellElement interface: document.createElement("td") must inherit property "headers" with the proper type]
expected: FAIL
@ -2267,12 +2261,6 @@
[HTMLTableCellElement interface: document.createElement("td") must inherit property "vAlign" with the proper type]
expected: FAIL
[HTMLTableCellElement must be primary interface of document.createElement("th")]
expected: FAIL
[Stringification of document.createElement("th")]
expected: FAIL
[HTMLTableCellElement interface: document.createElement("th") must inherit property "headers" with the proper type]
expected: FAIL
@ -7569,12 +7557,6 @@
[HTMLTableCellElement interface: attribute vAlign]
expected: FAIL
[HTMLTableCellElement must be primary interface of document.createElement("td")]
expected: FAIL
[Stringification of document.createElement("td")]
expected: FAIL
[HTMLTableCellElement interface: document.createElement("td") must inherit property "headers" with the proper type]
expected: FAIL
@ -7605,12 +7587,6 @@
[HTMLTableCellElement interface: document.createElement("td") must inherit property "vAlign" with the proper type]
expected: FAIL
[HTMLTableCellElement must be primary interface of document.createElement("th")]
expected: FAIL
[Stringification of document.createElement("th")]
expected: FAIL
[HTMLTableCellElement interface: document.createElement("th") must inherit property "headers" with the proper type]
expected: FAIL

13
tests/wpt/metadata/html/semantics/interfaces.html.ini
View file

@ -53,16 +53,3 @@
[Interfaces for SLOT]
expected: FAIL
[Interfaces for td]
expected: FAIL
[Interfaces for TD]
expected: FAIL
[Interfaces for th]
expected: FAIL
[Interfaces for TH]
expected: FAIL

4
tests/wpt/mozilla/meta/MANIFEST.json
View file

@ -26638,7 +26638,7 @@
"testharness"
],
"mozilla/collections.html": [
"4011ee6bf322eaacafafd98238c4261084397fde",
"8e06ffcc0933719b4b79ea6656d6635cc121d900",
"testharness"
],
"mozilla/createEvent-storageevent.html": [
@ -27038,7 +27038,7 @@
"testharness"
],
"mozilla/interfaces.html": [
"4863f4d1036e945cfaae1f112981fac3367b2e49",
"8bbde3b46a8e9d5ead6f9a2bf372d9647ad059be",
"testharness"
],
"mozilla/interfaces.js": [

4
tests/wpt/mozilla/tests/mozilla/collections.html
View file

@ -123,8 +123,8 @@ test(function() {
check_tag("caption", 1, [HTMLTableCaptionElement]);
check_tag("textarea", 1, [HTMLTextAreaElement]);
check_tag("q", 1, [HTMLQuoteElement]);
check_tag("th", 1, [HTMLTableCellElement, HTMLTableHeaderCellElement]);
check_tag("td", 1, [HTMLTableCellElement, HTMLTableDataCellElement]);
check_tag("th", 1, [HTMLTableCellElement]);
check_tag("td", 1, [HTMLTableCellElement]);
check_tag("col", 1, [HTMLTableColElement]);
check_tag("colgroup", 1, [HTMLTableColElement]);
check_tag("input", 2, [HTMLInputElement]);

2
tests/wpt/mozilla/tests/mozilla/interfaces.html
View file

@ -139,9 +139,7 @@ test_interfaces([
"HTMLTableCaptionElement",
"HTMLTableCellElement",
"HTMLTableColElement",
"HTMLTableDataCellElement",
"HTMLTableElement",
"HTMLTableHeaderCellElement",
"HTMLTableRowElement",
"HTMLTableSectionElement",
"HTMLTemplateElement",