mirror of
https://github.com/servo/servo.git
synced 2025-07-22 23:03:42 +01:00
webgl: Remove active_uniform related validation.
It's broken for uniform arrays, since uniform.id() stops being the index then. We need to add a more complex integration with angle for this to ever be correct. Unfortunately the ANGLE part that we should touch is C++, and it has destructors, so we need to hook destructors there, and I can't do it right now.
This commit is contained in:
parent
f470ad0d88
commit
6a15c2f245
2 changed files with 33 additions and 22 deletions
|
@ -116,6 +116,11 @@ impl WebGLShader {
|
|||
}
|
||||
|
||||
*self.info_log.borrow_mut() = Some(validator.info_log());
|
||||
// TODO(emilio): More data (like uniform data) should be collected
|
||||
// here to properly validate uniforms.
|
||||
//
|
||||
// This requires a more complex interface with ANGLE, using C++
|
||||
// bindings and being extremely cautious about destructing things.
|
||||
}
|
||||
}
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue