Improve spec conformance around request header validation (#33418)

* fix: improve spec conformance around request header validation

Signed-off-by: Shane Handley <shanehandley@fastmail.com>

* account for additional test passes

Signed-off-by: Shane Handley <shanehandley@fastmail.com>

* fix: remove redundant .to_vec call

Signed-off-by: Shane Handley <shanehandley@fastmail.com>

---------

Signed-off-by: Shane Handley <shanehandley@fastmail.com>
This commit is contained in:
shanehandley 2024-09-14 13:01:22 +10:00 committed by GitHub
parent 6071b4a961
commit 6a3cdc47ec
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
8 changed files with 263 additions and 482 deletions

View file

@ -1,267 +1,5 @@
[request-forbidden-headers.any.worker.html]
[header x-http-method-override is forbidden to use value TRACE]
expected: FAIL
[header x-http-method is forbidden to use value TRACE]
expected: FAIL
[header x-method-override is forbidden to use value TRACE]
expected: FAIL
[header X-HTTP-METHOD-OVERRIDE is forbidden to use value TRACE]
expected: FAIL
[header X-HTTP-METHOD is forbidden to use value TRACE]
expected: FAIL
[header X-METHOD-OVERRIDE is forbidden to use value TRACE]
expected: FAIL
[header x-http-method-override is forbidden to use value TRACK]
expected: FAIL
[header x-http-method is forbidden to use value TRACK]
expected: FAIL
[header x-method-override is forbidden to use value TRACK]
expected: FAIL
[header X-HTTP-METHOD-OVERRIDE is forbidden to use value TRACK]
expected: FAIL
[header X-HTTP-METHOD is forbidden to use value TRACK]
expected: FAIL
[header X-METHOD-OVERRIDE is forbidden to use value TRACK]
expected: FAIL
[header x-http-method-override is forbidden to use value CONNECT]
expected: FAIL
[header x-http-method is forbidden to use value CONNECT]
expected: FAIL
[header x-method-override is forbidden to use value CONNECT]
expected: FAIL
[header X-HTTP-METHOD-OVERRIDE is forbidden to use value CONNECT]
expected: FAIL
[header X-HTTP-METHOD is forbidden to use value CONNECT]
expected: FAIL
[header X-METHOD-OVERRIDE is forbidden to use value CONNECT]
expected: FAIL
[header x-http-method-override is forbidden to use value trace]
expected: FAIL
[header x-http-method is forbidden to use value trace]
expected: FAIL
[header x-method-override is forbidden to use value trace]
expected: FAIL
[header X-HTTP-METHOD-OVERRIDE is forbidden to use value trace]
expected: FAIL
[header X-HTTP-METHOD is forbidden to use value trace]
expected: FAIL
[header X-METHOD-OVERRIDE is forbidden to use value trace]
expected: FAIL
[header x-http-method-override is forbidden to use value track]
expected: FAIL
[header x-http-method is forbidden to use value track]
expected: FAIL
[header x-method-override is forbidden to use value track]
expected: FAIL
[header X-HTTP-METHOD-OVERRIDE is forbidden to use value track]
expected: FAIL
[header X-HTTP-METHOD is forbidden to use value track]
expected: FAIL
[header X-METHOD-OVERRIDE is forbidden to use value track]
expected: FAIL
[header x-http-method-override is forbidden to use value connect]
expected: FAIL
[header x-http-method is forbidden to use value connect]
expected: FAIL
[header x-method-override is forbidden to use value connect]
expected: FAIL
[header X-HTTP-METHOD-OVERRIDE is forbidden to use value connect]
expected: FAIL
[header X-HTTP-METHOD is forbidden to use value connect]
expected: FAIL
[header X-METHOD-OVERRIDE is forbidden to use value connect]
expected: FAIL
[header x-http-method-override is forbidden to use value trace,]
expected: FAIL
[header x-http-method is forbidden to use value trace,]
expected: FAIL
[header x-method-override is forbidden to use value trace,]
expected: FAIL
[header X-HTTP-METHOD-OVERRIDE is forbidden to use value trace,]
expected: FAIL
[header X-HTTP-METHOD is forbidden to use value trace,]
expected: FAIL
[header X-METHOD-OVERRIDE is forbidden to use value trace,]
expected: FAIL
[Access-Control-Request-Private-Network is a forbidden request header]
expected: FAIL
[request-forbidden-headers.any.sharedworker.html]
expected: ERROR
[request-forbidden-headers.any.html]
[header x-http-method-override is forbidden to use value TRACE]
expected: FAIL
[header x-http-method is forbidden to use value TRACE]
expected: FAIL
[header x-method-override is forbidden to use value TRACE]
expected: FAIL
[header X-HTTP-METHOD-OVERRIDE is forbidden to use value TRACE]
expected: FAIL
[header X-HTTP-METHOD is forbidden to use value TRACE]
expected: FAIL
[header X-METHOD-OVERRIDE is forbidden to use value TRACE]
expected: FAIL
[header x-http-method-override is forbidden to use value TRACK]
expected: FAIL
[header x-http-method is forbidden to use value TRACK]
expected: FAIL
[header x-method-override is forbidden to use value TRACK]
expected: FAIL
[header X-HTTP-METHOD-OVERRIDE is forbidden to use value TRACK]
expected: FAIL
[header X-HTTP-METHOD is forbidden to use value TRACK]
expected: FAIL
[header X-METHOD-OVERRIDE is forbidden to use value TRACK]
expected: FAIL
[header x-http-method-override is forbidden to use value CONNECT]
expected: FAIL
[header x-http-method is forbidden to use value CONNECT]
expected: FAIL
[header x-method-override is forbidden to use value CONNECT]
expected: FAIL
[header X-HTTP-METHOD-OVERRIDE is forbidden to use value CONNECT]
expected: FAIL
[header X-HTTP-METHOD is forbidden to use value CONNECT]
expected: FAIL
[header X-METHOD-OVERRIDE is forbidden to use value CONNECT]
expected: FAIL
[header x-http-method-override is forbidden to use value trace]
expected: FAIL
[header x-http-method is forbidden to use value trace]
expected: FAIL
[header x-method-override is forbidden to use value trace]
expected: FAIL
[header X-HTTP-METHOD-OVERRIDE is forbidden to use value trace]
expected: FAIL
[header X-HTTP-METHOD is forbidden to use value trace]
expected: FAIL
[header X-METHOD-OVERRIDE is forbidden to use value trace]
expected: FAIL
[header x-http-method-override is forbidden to use value track]
expected: FAIL
[header x-http-method is forbidden to use value track]
expected: FAIL
[header x-method-override is forbidden to use value track]
expected: FAIL
[header X-HTTP-METHOD-OVERRIDE is forbidden to use value track]
expected: FAIL
[header X-HTTP-METHOD is forbidden to use value track]
expected: FAIL
[header X-METHOD-OVERRIDE is forbidden to use value track]
expected: FAIL
[header x-http-method-override is forbidden to use value connect]
expected: FAIL
[header x-http-method is forbidden to use value connect]
expected: FAIL
[header x-method-override is forbidden to use value connect]
expected: FAIL
[header X-HTTP-METHOD-OVERRIDE is forbidden to use value connect]
expected: FAIL
[header X-HTTP-METHOD is forbidden to use value connect]
expected: FAIL
[header X-METHOD-OVERRIDE is forbidden to use value connect]
expected: FAIL
[header x-http-method-override is forbidden to use value trace,]
expected: FAIL
[header x-http-method is forbidden to use value trace,]
expected: FAIL
[header x-method-override is forbidden to use value trace,]
expected: FAIL
[header X-HTTP-METHOD-OVERRIDE is forbidden to use value trace,]
expected: FAIL
[header X-HTTP-METHOD is forbidden to use value trace,]
expected: FAIL
[header X-METHOD-OVERRIDE is forbidden to use value trace,]
expected: FAIL
[Access-Control-Request-Private-Network is a forbidden request header]
expected: FAIL
[request-forbidden-headers.any.serviceworker.html]
expected: ERROR

View file

@ -1,21 +1,9 @@
[request-private-network-headers.tentative.any.worker.html]
[Access-Control-Request-Private-Network is a forbidden request header]
expected: FAIL
[Adding invalid request header "Access-Control-Request-Private-Network: KO"]
expected: FAIL
[request-private-network-headers.tentative.any.serviceworker.html]
expected: ERROR
[request-private-network-headers.tentative.any.html]
[Access-Control-Request-Private-Network is a forbidden request header]
expected: FAIL
[Adding invalid request header "Access-Control-Request-Private-Network: KO"]
expected: FAIL
[request-private-network-headers.tentative.any.sharedworker.html]
expected: ERROR