Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-23 07:13:52 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #25948 - NeverHappened:accept-only-connected-attributes-for-checkbox-radio-activation, r=jdm

Browse source 
Accept only connected attributes for checkbox and radio activation behavior

<!-- Please describe your changes on the following line: -->
Accept only connected attributes for checkbox and radio activation behavior

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #25906
- [x] WPT tests were already here
This commit is contained in:
bors-servo 2020-03-12 13:38:47 -04:00 • committed by GitHub
commit 6ab923c8e8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

3
components/script/dom/htmlinputelement.rs
View file

@ -2488,6 +2488,9 @@ impl Activatable for HTMLInputElement {
// https://html.spec.whatwg.org/multipage/#checkbox-state-(type=checkbox):activation-behavior
// https://html.spec.whatwg.org/multipage/#radio-button-state-(type=radio):activation-behavior
// Check if document owner is fully active
if !self.upcast::<Node>().is_connected() {
return ();
}
let target = self.upcast::<EventTarget>();
target.fire_bubbling_event(atom!("input"));
target.fire_bubbling_event(atom!("change"));

12
tests/wpt/metadata/dom/events/Event-dispatch-detached-input-and-change.html.ini
View file

@ -2,21 +2,9 @@
[attached to shadow dom radio should emit input and change events on click().]
expected: FAIL
[detached checkbox should not emit input or change events on click().]
expected: FAIL
[attached to shadow dom checkbox should emit input and change events on click().]
expected: FAIL
[detached radio should not emit input or change events on click().]
expected: FAIL
[detached radio should not emit input or change events on dispatchEvent(new MouseEvent('click')).]
expected: FAIL
[detached checkbox should not emit input or change events on dispatchEvent(new MouseEvent('click')).]
expected: FAIL
[attached to shadow dom checkbox should emit input and change events on dispatchEvent(new MouseEvent('click')).]
expected: FAIL