Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 14:10:11 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #26450 - PeterZhizhin:add_referrerpolicy_to_list_of_relevant_mutations, r=jdm

Browse source 
Add referrerpolicy to list of relevant mutations

<!-- Please describe your changes on the following line: -->

`img.referrerPolicy` change now mutates the image.
Not all `referrerPolicy` attribute changes result in an image update event.
Only valid changes are reflected.

All referrerpolicy tests inside `relevant-mutations.html` WPT test now pass.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26388

<!-- Either: -->
- [x] These have tests:
```
./mach test-wpt tests/wpt/web-platform-tests/html/semantics/embedded-content/the-img-element/relevant-mutations.html
```
This commit is contained in:
bors-servo 2020-05-07 08:45:12 -04:00 • committed by GitHub
commit 6aec2c8594
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 58 additions and 54 deletions
Download patch file Download diff file Expand all files Collapse all files

6
tests/wpt/metadata/custom-elements/reactions/HTMLImageElement.html.ini
View file

@ -1,10 +1,4 @@
[HTMLImageElement.html]
[referrerPolicy on HTMLImageElement must enqueue an attributeChanged reaction when replacing an existing attribute]
expected: FAIL
[referrerPolicy on HTMLImageElement must enqueue an attributeChanged reaction when adding a new attribute]
expected: FAIL
[decoding on HTMLImageElement must enqueue an attributeChanged reaction when replacing an existing attribute]
expected: FAIL

9
tests/wpt/metadata/html/dom/idlharness.https.html.ini
View file

@ -2703,9 +2703,6 @@
[HTMLInputElement interface: createInput("radio") must inherit property "height" with the proper type]
expected: FAIL
[HTMLImageElement interface: document.createElement("img") must inherit property "referrerPolicy" with the proper type]
expected: FAIL
[HTMLDialogElement interface: operation showModal()]
expected: FAIL
@ -3045,9 +3042,6 @@
[HTMLLinkElement interface: document.createElement("link") must inherit property "imageSizes" with the proper type]
expected: FAIL
[HTMLImageElement interface: attribute referrerPolicy]
expected: FAIL
[HTMLInputElement interface: createInput("time") must inherit property "align" with the proper type]
expected: FAIL
@ -3276,9 +3270,6 @@
[HTMLObjectElement interface: attribute width]
expected: FAIL
[HTMLImageElement interface: new Image() must inherit property "referrerPolicy" with the proper type]
expected: FAIL
[HTMLObjectElement interface: operation getSVGDocument()]
expected: FAIL

37
tests/wpt/metadata/html/semantics/embedded-content/the-img-element/relevant-mutations.html.ini
View file

@ -29,40 +29,3 @@
[picture is inserted; img has src]
expected: FAIL
[referrerpolicy no-referrer-when-downgrade to empty, src already set]
expected: FAIL
[referrerpolicy no-referrer-when-downgrade to no-referrer, src already set]
expected: FAIL
[referrerpolicy absent to no-referrer-when-downgrade, src already set]
expected: FAIL
[referrerpolicy no-referrer-when-downgrade to absent, src already set]
expected: FAIL
[referrerpolicy no-referrer to invalid, src already set]
expected: FAIL
[referrerpolicy no-referrer to no-referrer-when-downgrade, src already set]
expected: FAIL
[referrerpolicy empty to no-referrer-when-downgrade, src already set]
expected: FAIL
[referrerpolicy no-referrer to empty, src already set]
expected: FAIL
[referrerpolicy absent to no-referrer, src already set]
expected: FAIL
[referrerpolicy no-referrer-when-downgrade to invalid, src already set]
expected: FAIL
[referrerpolicy no-referrer to absent, src already set]
expected: FAIL
[referrerpolicy empty to no-referrer, src already set]
expected: FAIL