mirror of
https://github.com/servo/servo.git
synced 2025-08-03 04:30:10 +01:00
style: Gracefully handle errors creating shared memory UA style sheets.
We still panic in a debug build, so that developers can notice when they need to add a new static atom after modifying UA sheets. We also add telemetry to note when this happens, add an app note to a crash report, in case any crash later on occurs, and re-up the existing, expired shared memory sheet telemetry probes so we can look at them again. Differential Revision: https://phabricator.services.mozilla.com/D73188
This commit is contained in:
parent
709c52fefb
commit
6bae0b99ca
10 changed files with 184 additions and 122 deletions
|
@ -258,20 +258,20 @@ impl<T> Locked<T> {
|
|||
|
||||
#[cfg(feature = "gecko")]
|
||||
impl<T: ToShmem> ToShmem for Locked<T> {
|
||||
fn to_shmem(&self, builder: &mut SharedMemoryBuilder) -> ManuallyDrop<Self> {
|
||||
fn to_shmem(&self, builder: &mut SharedMemoryBuilder) -> to_shmem::Result<Self> {
|
||||
let guard = self.shared_lock.read();
|
||||
ManuallyDrop::new(Locked {
|
||||
Ok(ManuallyDrop::new(Locked {
|
||||
shared_lock: SharedRwLock::read_only(),
|
||||
data: UnsafeCell::new(ManuallyDrop::into_inner(
|
||||
self.read_with(&guard).to_shmem(builder),
|
||||
self.read_with(&guard).to_shmem(builder)?,
|
||||
)),
|
||||
})
|
||||
}))
|
||||
}
|
||||
}
|
||||
|
||||
#[cfg(feature = "servo")]
|
||||
impl<T: ToShmem> ToShmem for Locked<T> {
|
||||
fn to_shmem(&self, _builder: &mut SharedMemoryBuilder) -> ManuallyDrop<Self> {
|
||||
fn to_shmem(&self, _builder: &mut SharedMemoryBuilder) -> to_shmem::Result<Self> {
|
||||
panic!("ToShmem not supported in Servo currently")
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue