Created CanvasRect fro OffscreenCanvas and Updated Testcases

This commit is contained in:
Maharsh 2019-03-29 15:12:53 -04:00
parent 85ed1812ee
commit 6c6fb676b7
188 changed files with 496 additions and 34 deletions

3
.vs/ProjectSettings.json Normal file
View file

@ -0,0 +1,3 @@
{
"CurrentProjectSetting": "x64-Debug (default)"
}

View file

@ -0,0 +1,7 @@
{
"ExpandedNodes": [
""
],
"SelectedNode": "\\components",
"PreviewInSolutionExplorer": false
}

BIN
.vs/servo/v15/.suo Normal file

Binary file not shown.

BIN
.vs/slnx.sqlite Normal file

Binary file not shown.

View file

@ -62,8 +62,8 @@ enum CanvasFillOrStrokeStyle {
#[dom_struct]
pub struct CanvasRenderingContext2D {
reflector_: Reflector,
#[ignore_malloc_size_of = "Defined in ipc-channel"]
ipc_renderer: IpcSender<CanvasMsg>,
//#[ignore_malloc_size_of = "Defined in ipc-channel"]
//ipc_renderer: IpcSender<CanvasMsg>,
/// For rendering contexts created by an HTML canvas element, this is Some,
/// for ones created by a paint worklet, this is None.
canvas: Option<Dom<HTMLCanvasElement>>,
@ -77,7 +77,8 @@ pub struct CanvasRenderingContext2D {
state: DomRefCell<CanvasContextState>,
saved_states: DomRefCell<Vec<CanvasContextState>>,
origin_clean: Cell<bool>,
canvas_id: CanvasId,
//canvas_id: CanvasId,
canvas_state: DomRefCell<CanvasState>,
}
#[must_root]
@ -121,6 +122,77 @@ impl CanvasContextState {
}
}
#[must_root]
#[derive(Clone, JSTraceable, MallocSizeOf)]
pub struct CanvasState {
//reflector_: Reflector,
#[ignore_malloc_size_of = "Defined in ipc-channel"]
ipc_renderer: IpcSender<CanvasMsg>,
canvas_id: CanvasId,
}
impl CanvasState {
pub fn new(
global: &GlobalScope,
) -> CanvasState {
let (sender, receiver) =
profiled_ipc::channel(global.time_profiler_chan().clone()).unwrap();
let (ipc_renderer, canvas_id) = receiver.recv().unwrap();
debug!("Done.");
CanvasState {
//reflector_: Reflector::new(),
ipc_renderer: ipc_renderer,
canvas_id: canvas_id,
}
}
pub fn get_canvas_id(&self) -> CanvasId {
self.canvas_id.clone()
}
pub fn send_canvas_2d_msg(&self, msg: Canvas2dMsg) {
self.ipc_renderer
.send(CanvasMsg::Canvas2d(msg, self.get_canvas_id()))
.unwrap()
}
fn create_drawable_rect(&self, x: f64, y: f64, w: f64, h: f64) -> Option<Rect<f32>> {
if !([x, y, w, h].iter().all(|val| val.is_finite())) {
return None;
}
if w == 0.0 && h == 0.0 {
return None;
}
Some(Rect::new(
Point2D::new(x as f32, y as f32),
Size2D::new(w as f32, h as f32),
))
}
// https://html.spec.whatwg.org/multipage/#dom-context-2d-fillrect
pub fn FillRect(&self, x: f64, y: f64, width: f64, height: f64) {
if let Some(rect) = self.create_drawable_rect(x, y, width, height) {
self.send_canvas_2d_msg(Canvas2dMsg::FillRect(rect));
}
}
// https://html.spec.whatwg.org/multipage/#dom-context-2d-clearrect
pub fn ClearRect(&self, x: f64, y: f64, width: f64, height: f64) {
if let Some(rect) = self.create_drawable_rect(x, y, width, height) {
self.send_canvas_2d_msg(Canvas2dMsg::ClearRect(rect));
}
}
// https://html.spec.whatwg.org/multipage/#dom-context-2d-strokerect
pub fn StrokeRect(&self, x: f64, y: f64, width: f64, height: f64) {
if let Some(rect) = self.create_drawable_rect(x, y, width, height) {
self.send_canvas_2d_msg(Canvas2dMsg::StrokeRect(rect));
}
}
}
impl CanvasRenderingContext2D {
pub fn new_inherited(
global: &GlobalScope,
@ -137,19 +209,20 @@ impl CanvasRenderingContext2D {
script_to_constellation_chan
.send(ScriptMsg::CreateCanvasPaintThread(size, sender))
.unwrap();
let (ipc_renderer, canvas_id) = receiver.recv().unwrap();
//let (canvas_state.ipc_renderer, canvas_id) = receiver.recv().unwrap();
debug!("Done.");
CanvasRenderingContext2D {
reflector_: Reflector::new(),
ipc_renderer: ipc_renderer,
canvas: canvas.map(Dom::from_ref),
//ipc_renderer: ipc_renderer,
image_cache: image_cache,
missing_image_urls: DomRefCell::new(Vec::new()),
base_url: base_url,
state: DomRefCell::new(CanvasContextState::new()),
saved_states: DomRefCell::new(Vec::new()),
origin_clean: Cell::new(true),
canvas_id: canvas_id,
//canvas_id: canvas_id,
canvas_state: DomRefCell::new(CanvasState::new(global)),
}
}
@ -174,8 +247,8 @@ impl CanvasRenderingContext2D {
// https://html.spec.whatwg.org/multipage/#concept-canvas-set-bitmap-dimensions
pub fn set_bitmap_dimensions(&self, size: Size2D<u32>) {
self.reset_to_initial_state();
self.ipc_renderer
.send(CanvasMsg::Recreate(size, self.get_canvas_id()))
self.canvas_state.borrow().ipc_renderer
.send(CanvasMsg::Recreate(size, self.canvas_state.borrow().get_canvas_id()))
.unwrap();
}
@ -366,7 +439,7 @@ impl CanvasRenderingContext2D {
match *context {
CanvasContext::Context2d(ref context) => {
context.send_canvas_2d_msg(Canvas2dMsg::DrawImageInOther(
self.get_canvas_id(),
self.canvas_state.borrow().get_canvas_id(),
image_size,
dest_rect,
source_rect,
@ -475,7 +548,7 @@ impl CanvasRenderingContext2D {
mem::replace(&mut self.missing_image_urls.borrow_mut(), vec![])
}
fn create_drawable_rect(&self, x: f64, y: f64, w: f64, h: f64) -> Option<Rect<f32>> {
/*fn create_drawable_rect(&self, x: f64, y: f64, w: f64, h: f64) -> Option<Rect<f32>> {
if !([x, y, w, h].iter().all(|val| val.is_finite())) {
return None;
}
@ -488,7 +561,7 @@ impl CanvasRenderingContext2D {
Point2D::new(x as f32, y as f32),
Size2D::new(w as f32, h as f32),
))
}
}*/
fn parse_color(&self, string: &str) -> Result<RGBA, ()> {
let mut input = ParserInput::new(string);
@ -528,17 +601,15 @@ impl CanvasRenderingContext2D {
}
pub fn get_canvas_id(&self) -> CanvasId {
self.canvas_id.clone()
self.canvas_state.borrow().get_canvas_id()
}
pub fn send_canvas_2d_msg(&self, msg: Canvas2dMsg) {
self.ipc_renderer
.send(CanvasMsg::Canvas2d(msg, self.get_canvas_id()))
.unwrap()
self.canvas_state.borrow().send_canvas_2d_msg(msg)
}
pub fn get_ipc_renderer(&self) -> IpcSender<CanvasMsg> {
self.ipc_renderer.clone()
self.canvas_state.borrow().ipc_renderer.clone()
}
pub fn origin_is_clean(&self) -> bool {
@ -585,12 +656,12 @@ pub trait LayoutCanvasRenderingContext2DHelpers {
impl LayoutCanvasRenderingContext2DHelpers for LayoutDom<CanvasRenderingContext2D> {
#[allow(unsafe_code)]
unsafe fn get_ipc_renderer(&self) -> IpcSender<CanvasMsg> {
(*self.unsafe_get()).ipc_renderer.clone()
(*self.unsafe_get()).canvas_state.borrow().ipc_renderer.clone()
}
#[allow(unsafe_code)]
unsafe fn get_canvas_id(&self) -> CanvasId {
(*self.unsafe_get()).canvas_id.clone()
(*self.unsafe_get()).canvas_state.borrow().get_canvas_id()
}
}
@ -747,26 +818,20 @@ impl CanvasRenderingContext2DMethods for CanvasRenderingContext2D {
// https://html.spec.whatwg.org/multipage/#dom-context-2d-fillrect
fn FillRect(&self, x: f64, y: f64, width: f64, height: f64) {
if let Some(rect) = self.create_drawable_rect(x, y, width, height) {
self.send_canvas_2d_msg(Canvas2dMsg::FillRect(rect));
self.mark_as_dirty();
}
self.canvas_state.borrow().FillRect(x, y, width, height);
self.mark_as_dirty();
}
// https://html.spec.whatwg.org/multipage/#dom-context-2d-clearrect
fn ClearRect(&self, x: f64, y: f64, width: f64, height: f64) {
if let Some(rect) = self.create_drawable_rect(x, y, width, height) {
self.send_canvas_2d_msg(Canvas2dMsg::ClearRect(rect));
self.mark_as_dirty();
}
self.canvas_state.borrow().ClearRect(x, y, width, height);
self.mark_as_dirty();
}
// https://html.spec.whatwg.org/multipage/#dom-context-2d-strokerect
fn StrokeRect(&self, x: f64, y: f64, width: f64, height: f64) {
if let Some(rect) = self.create_drawable_rect(x, y, width, height) {
self.send_canvas_2d_msg(Canvas2dMsg::StrokeRect(rect));
self.mark_as_dirty();
}
self.canvas_state.borrow().StrokeRect(x, y, width, height);
self.mark_as_dirty();
}
// https://html.spec.whatwg.org/multipage/#dom-context-2d-beginpath
@ -1458,8 +1523,8 @@ impl CanvasRenderingContext2DMethods for CanvasRenderingContext2D {
impl Drop for CanvasRenderingContext2D {
fn drop(&mut self) {
if let Err(err) = self
.ipc_renderer
.send(CanvasMsg::Close(self.get_canvas_id()))
.canvas_state.borrow().ipc_renderer
.send(CanvasMsg::Close(self.canvas_state.borrow().get_canvas_id()))
{
warn!("Could not close canvas: {}", err)
}

View file

@ -2,10 +2,12 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
use crate::dom::bindings::cell::DomRefCell;
use crate::dom::bindings::codegen::Bindings::OffscreenCanvasRenderingContext2DBinding;
use crate::dom::bindings::codegen::Bindings::OffscreenCanvasRenderingContext2DBinding::OffscreenCanvasRenderingContext2DMethods;
use crate::dom::bindings::reflector::{reflect_dom_object, Reflector};
use crate::dom::bindings::root::{Dom, DomRoot};
use crate::dom::canvasrenderingcontext2d::CanvasState;
use crate::dom::globalscope::GlobalScope;
use crate::dom::offscreencanvas::OffscreenCanvas;
use dom_struct::dom_struct;
@ -15,6 +17,7 @@ use euclid::Size2D;
pub struct OffscreenCanvasRenderingContext2D {
reflector_: Reflector,
canvas: Option<Dom<OffscreenCanvas>>,
canvas_state: DomRefCell<CanvasState>,
}
impl OffscreenCanvasRenderingContext2D {
@ -26,6 +29,7 @@ impl OffscreenCanvasRenderingContext2D {
OffscreenCanvasRenderingContext2D {
reflector_: Reflector::new(),
canvas: canvas.map(Dom::from_ref),
canvas_state: DomRefCell::new(CanvasState::new(_global)),
}
}
@ -52,4 +56,22 @@ impl OffscreenCanvasRenderingContext2DMethods for OffscreenCanvasRenderingContex
fn Canvas(&self) -> DomRoot<OffscreenCanvas> {
DomRoot::from_ref(self.canvas.as_ref().expect("No canvas."))
}
// https://html.spec.whatwg.org/multipage/#dom-context-2d-fillrect
fn FillRect(&self, x: f64, y: f64, width: f64, height: f64) {
self.canvas_state.borrow().FillRect(x, y, width, height);
//self.mark_as_dirty();
}
// https://html.spec.whatwg.org/multipage/#dom-context-2d-clearrect
fn ClearRect(&self, x: f64, y: f64, width: f64, height: f64) {
self.canvas_state.borrow().ClearRect(x, y, width, height);
//self.mark_as_dirty();
}
// https://html.spec.whatwg.org/multipage/#dom-context-2d-strokerect
fn StrokeRect(&self, x: f64, y: f64, width: f64, height: f64) {
self.canvas_state.borrow().StrokeRect(x, y, width, height);
//self.mark_as_dirty();
}
}

View file

@ -111,7 +111,7 @@ interface CanvasFilters {
//attribute DOMString filter; // (default "none")
};
[Exposed=(PaintWorklet, Window), NoInterfaceObject]
[Exposed=(PaintWorklet, Window, Worker), NoInterfaceObject]
interface CanvasRect {
// rects
void clearRect(unrestricted double x, unrestricted double y, unrestricted double w, unrestricted double h);

View file

@ -8,6 +8,8 @@ interface OffscreenCanvasRenderingContext2D {
//void commit();
readonly attribute OffscreenCanvas canvas;
};
OffscreenCanvasRenderingContext2D implements CanvasRect;
//OffscreenCanvasRenderingContext2D includes CanvasState;
//OffscreenCanvasRenderingContext2D includes CanvasTransform;
@ -16,7 +18,6 @@ interface OffscreenCanvasRenderingContext2D {
//OffscreenCanvasRenderingContext2D includes CanvasFillStrokeStyles;
//OffscreenCanvasRenderingContext2D includes CanvasShadowStyles;
//OffscreenCanvasRenderingContext2D includes CanvasFilters;
//OffscreenCanvasRenderingContext2D includes CanvasRect;
//OffscreenCanvasRenderingContext2D includes CanvasDrawPath;
//OffscreenCanvasRenderingContext2D includes CanvasText;
//OffscreenCanvasRenderingContext2D includes CanvasDrawImage;
@ -24,3 +25,7 @@ interface OffscreenCanvasRenderingContext2D {
//OffscreenCanvasRenderingContext2D includes CanvasPathDrawingStyles;
//OffscreenCanvasRenderingContext2D includes CanvasTextDrawingStyles;
//OffscreenCanvasRenderingContext2D includes CanvasPath;

View file

@ -0,0 +1,2 @@
[2d.composite.canvas.copy.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.composite.canvas.copy.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.composite.canvas.destination-atop.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.composite.canvas.destination-atop.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.composite.canvas.destination-in.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.composite.canvas.destination-in.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.composite.canvas.destination-out.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.composite.canvas.destination-out.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.composite.canvas.destination-over.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.composite.canvas.destination-over.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.composite.canvas.lighter.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.composite.canvas.lighter.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.composite.canvas.source-atop.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.composite.canvas.source-atop.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.composite.canvas.source-in.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.composite.canvas.source-in.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.composite.canvas.source-out.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.composite.canvas.source-out.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.composite.canvas.source-over.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.composite.canvas.source-over.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.composite.canvas.xor.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.composite.canvas.xor.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.composite.operation.clear.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.composite.operation.clear.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.composite.operation.get.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.composite.operation.get.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.drawImage.3arg.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.drawImage.3arg.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.drawImage.animated.poster.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.drawImage.animated.poster.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.drawImage.broken.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.drawImage.broken.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.drawImage.floatsource.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.drawImage.floatsource.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.drawImage.null.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.drawImage.null.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.drawImage.svg.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.drawImage.svg.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.drawImage.wrongtype.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.drawImage.wrongtype.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.gradient.linear.nonfinite.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.gradient.linear.nonfinite.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.gradient.radial.nonfinite.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.gradient.radial.nonfinite.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.pattern.crosscanvas.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.pattern.crosscanvas.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.pattern.image.null.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.pattern.image.null.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.pattern.image.string.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.pattern.image.string.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.pattern.image.undefined.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.pattern.image.undefined.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.pattern.paint.norepeat.coord2.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.pattern.paint.norepeat.coord2.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.pattern.paint.repeat.coord2.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.pattern.paint.repeat.coord2.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.pattern.paint.repeat.coord3.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.pattern.paint.repeat.coord3.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.line.cap.valid.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.line.cap.valid.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.line.join.valid.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.line.join.valid.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.imageData.create1.zero.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.imageData.create1.zero.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.imageData.create2.nonfinite.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.imageData.create2.nonfinite.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.imageData.get.nonfinite.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.imageData.get.nonfinite.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.imageData.put.null.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.imageData.put.null.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.imageData.put.wrongtype.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.imageData.put.wrongtype.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.shadow.attributes.shadowBlur.valid.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.shadow.attributes.shadowBlur.valid.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.shadow.attributes.shadowOffset.valid.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.shadow.attributes.shadowOffset.valid.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.shadow.pattern.alpha.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.shadow.pattern.alpha.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.shadow.pattern.basic.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.shadow.pattern.basic.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.shadow.pattern.transparent.1.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.shadow.pattern.transparent.1.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.shadow.pattern.transparent.2.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.shadow.pattern.transparent.2.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.text.align.valid.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.text.align.valid.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.text.baseline.valid.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.text.baseline.valid.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.text.draw.align.center.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.text.draw.align.center.worker.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.text.draw.align.end.ltr.html]
expected: CRASH

View file

@ -0,0 +1,2 @@
[2d.text.draw.align.end.ltr.worker.html]
expected: CRASH

Some files were not shown because too many files have changed in this diff Show more